Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#86 Add option to write description at end of line instead of begin of line #137

merged 1 commit into from Sep 9, 2022


Copy link

@LeoVie LeoVie commented Sep 8, 2022

This fixes #86

Hi, I've added the flag showDescriptionAtLineEnd to the progress bar. I'm not sure, if I am happy with this naming, but it was the best that came into my mind. :)

The part starting at line 828 is quite cluttered now. I suggest, extracting a function with early returns, but I did not wanted to let this pull request getting too big. If you agree, I can create another pull request for this refactoring.

Copy link

schollz commented Sep 9, 2022

Looks great!

Yep, I'm open to refactoring, feel free to make another PR with a refactor.

@schollz schollz merged commit 9e099d3 into schollz:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Add an option to put the description after the bar
2 participants