Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

__eq__ method for NodeModel is broken #230

Closed
coffenbacher opened this issue Dec 13, 2013 · 0 comments
Closed

__eq__ method for NodeModel is broken #230

coffenbacher opened this issue Dec 13, 2013 · 0 comments

Comments

@coffenbacher
Copy link
Contributor

Two issues here:

 pk2 = self.__get_pk_val() # typo, should be checking the val on other

image

 NodeModel() == None # will fail since __eq__ calls _get_pk_val

image
coffenbacher added a commit to coffenbacher/neo4django that referenced this issue Dec 13, 2013
@coffenbacher
Updating __eq__ method for base NodeModel, fixes issue scholrly#230
c68c718
coffenbacher added a commit to coffenbacher/neo4django that referenced this issue Dec 13, 2013
@coffenbacher
Committing fix for issue scholrly#230, fixes __eq__ behavior on base …
47b6dd7 
…NodeModel
mhluongo added a commit that referenced this issue Dec 30, 2013
@mhluongo
Merge pull request #231 from coffenbacher/fix-nodemodel-eq
b46afc4 
Committing fix for issue #230, fixes __eq__ behavior on base NodeModel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coffenbacher @mhluongo