-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[format] Retain foreign data #2
Comments
This is not supported (yet). I would like to avoid it as it poses some performance problems. And there is the userData dict that is intended to store custom data. the userData property is available at font, glyph, layer, node, fontMaster. I just saw that some of them are missing in the spec. |
The performance problems only effect data you don't anticipate though,
right? So if you enable this and allow users to opt in to tracking foreign
keys, you can build up a list/dictionary of anticipated keys/types?
|
The performance is mostly a problem when saving. I don’t use a library or intermediate representation to write the file. The keys should be in alphabetical order and so I have to check after each of my keys, if there is a custom key available... |
What if there was a key like alwaysRoundtripKeys (so,at the top) which only
when present triggered this check? :)
|
Problem
I made an example file, saved it, copied it, edited it in a text editor to add some "foreign" data, and then opened and saved it as a 3rd file. That file lost my data.
Files are here: https://gist.github.com/davelab6/c5fa105bcac695e83cae
Expected result
The 3rd file still has my data
Suggestion
Glyphs should retain arbitrary plist-conformant data in glyphs file
The text was updated successfully, but these errors were encountered: