Skip to content
Browse files

filebuf: Check the return value for `close`

  • Loading branch information...
1 parent d96c386 commit 5daca042c642bf123f0b0a39c1ad32ca0afcac70 @vmg vmg committed Aug 3, 2012
Showing with 7 additions and 2 deletions.
  1. +7 −2 src/filebuf.c
View
9 src/filebuf.c
@@ -319,10 +319,15 @@ int git_filebuf_commit(git_filebuf *file, mode_t mode)
if (verify_last_error(file) < 0)
goto on_error;
- p_close(file->fd);
- file->fd = -1;
file->fd_is_open = false;
+ if (p_close(file->fd) < 0) {
+ giterr_set(GITERR_OS, "Failed to close file at '%s'", file->path_lock);
+ goto on_error;
+ }
+
+ file->fd = -1;
+
if (p_chmod(file->path_lock, mode)) {
giterr_set(GITERR_OS, "Failed to set attributes for file at '%s'", file->path_lock);
goto on_error;

0 comments on commit 5daca04

Please sign in to comment.
Something went wrong with that request. Please try again.