Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fixes #114

Merged
merged 2 commits into from Aug 8, 2019

Conversation

@zakame
Copy link
Contributor

commented Aug 8, 2019

  • Fix nginx setup in acme_client test cookbook (was looking to upgrade nginx cookbook dependency to v10 but there's a lot of breaking changes there, so work around for now.)
  • Use Pebble v1.0.1 instead of master/v2.x (in a similar situation to the nginx cookbook above.)

zakame added some commits Aug 8, 2019

Use Pebble v1.0.1 for testing
Pebble v2.x has breaking changes that need some futher overhaul here,
but for now use the v1.0.1 version so tests can pass once more.

Also ensure that available packages are updated in Debian-based testing
platforms.
@thoutenbos

This comment has been minimized.

Copy link
Collaborator

commented Aug 8, 2019

Cool stuff!

@thoutenbos thoutenbos merged commit 3846b7b into schubergphilis:master Aug 8, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@zakame

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

Thanks! Forgot one more commit though, I'll just make another PR

@zakame

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

Ah just saw 38e72bc 👍

@thoutenbos

This comment has been minimized.

Copy link
Collaborator

commented Aug 8, 2019

Very happy to have the Travis working again! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.