Add more options.#6
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds new configuration options to the Metal Compiler Plugin for enhanced logging control and dependency path management. The changes allow users to customize logging behavior with prefixes and verbosity levels, and to specify subdirectory paths when including dependency headers.
- Added
dependency-path-suffixoption to append subdirectories (e.g., "include") to dependency paths - Added
logging-prefixoption to customize log message prefixes for better identification - Added
verbose-loggingoption for more detailed debug output - Updated documentation with new configuration options and usage examples
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Added documentation for new configuration options (include-dependencies, dependency-path-suffix, verbose-logging, logging-prefix) with usage examples |
| Plugins/MetalCompilerPlugin/MetalPlugin.swift | Implemented the new configuration options, added prefix support to logging functions, and enhanced dependency path handling with optional suffix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.