New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7 amend libravatar test to use Test::MockRandom #9

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@lharey
Contributor

lharey commented Aug 10, 2016

Hi

As per our email re the PR request challenge

This should hopefully resolve #7

Regards
Lisa

@schwern

This comment has been minimized.

Show comment
Hide comment
@schwern

schwern Aug 11, 2016

Owner

Other distributions might do it differently, but in general don't rebuild the distmeta as part of a PR, even if you're adding dependencies. It'll cause conflicts. The rebuild doesn't have to happen until release.

No worries, I'll fix it up.

This is why trailing commas should be left alone. ;)

Owner

schwern commented Aug 11, 2016

Other distributions might do it differently, but in general don't rebuild the distmeta as part of a PR, even if you're adding dependencies. It'll cause conflicts. The rebuild doesn't have to happen until release.

No worries, I'll fix it up.

This is why trailing commas should be left alone. ;)

schwern added a commit that referenced this pull request Aug 11, 2016

@schwern

This comment has been minimized.

Show comment
Hide comment
@schwern

schwern Aug 11, 2016

Owner

merged as 85f21d0 due to conflicts

Owner

schwern commented Aug 11, 2016

merged as 85f21d0 due to conflicts

@schwern schwern closed this Aug 11, 2016

@schwern

This comment has been minimized.

Show comment
Hide comment
@schwern

schwern Aug 11, 2016

Owner

No open issues, thanks!

Owner

schwern commented Aug 11, 2016

No open issues, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment