Permalink
Browse files

RT 74444 - install_lib.pl emits warnings when installperl is run with…

… destdir

running the following produces 7 warnings like this on my system:
'LD_LIBRARY_PATH=/usr/home/build/perl-5.12.0  ./perl installperl --destdir=/var/local/tmp/perl-root'

Use of uninitialized value $dev2 in numeric eq (==) at ./install_lib.pl line 123.

replacing == with ~~ (the smart match operator) seems to be the best DWIM fix.
  • Loading branch information...
1 parent 2273b9b commit 4c3ca3f48a3e5f7633cf0ffcb5ac673bdbcf7f45 @toddr toddr committed with rafl Sep 1, 2010
Showing with 1 addition and 1 deletion.
  1. +1 −1 install_lib.pl
View
@@ -120,7 +120,7 @@ sub samepath {
my($dev1, $ino1, $dev2, $ino2);
($dev1, $ino1) = stat($p1);
($dev2, $ino2) = stat($p2);
- ($dev1 == $dev2 && $ino1 == $ino2);
+ ($dev1 ~~ $dev2 && $ino1 ~~ $ino2);
}
else {
1;

0 comments on commit 4c3ca3f

Please sign in to comment.