Skip to content
This repository

use of Digest::SHA instead of Digest::SHA1 in checksum #196

Closed
carnil opened this Issue May 07, 2011 · 2 comments

2 participants

carnil Michael G. Schwern
carnil
carnil commented May 07, 2011

Hi!

lib/perl5i/1/Meta/Instance.pm and lib/perl5i/2/Meta/Instance.pm both use Digest::SHA1 for the sha1 checksum. Digest::SHA is part of the standard perl distribution since perl v5.9.3 so this reduces the number of external dependencies by one.

Would it be possible to have perl5i using Digest::SHA? Most of the functionality (except sha1_transform) of Digest::SHA1 is also provided by Digest::SHA. Switching from Digest::SHA1 to Digest::SHA should be in principle as easy as substituting the use of Digest::SHA1 with Digest::SHA.

Many thanks for consideration! Backgound behind this request is in [1], the Debian Perl Group would like to drop the package providing Digest::SHA1, since Digest::SHA in perl core since 5.9.3 provides a similar interface.

[1] http://deb.li/digestsha

Bests
Salvatore

Michael G. Schwern
Owner
schwern commented May 09, 2011

Less dependencies good. I don't think I realized one was core and one is not when it was written.

Approved. Do it.

Mike Doherty doherty referenced this issue from a commit June 05, 2011
Commit has since been removed from the repository and is no longer available.
Mike Doherty doherty referenced this issue from a commit in doherty/perl5i June 05, 2011
Mike Doherty Use core module Digest::SHA instead of Digest::SHA1
Fixes #196
184c211
Michael G. Schwern schwern referenced this issue from a commit September 24, 2011
Michael G. Schwern Use the core Digest::SHA instead of Digest::SHA1.
Eliminate a CPAN dependency.  We don't need the rest of Digest::SHA1 yet.

For #196
9434c3c
Michael G. Schwern
Owner

Done!

Michael G. Schwern schwern closed this September 24, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.