Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acrescenta a obrigatoriedade de <contrib-id contrib-id-type="orcid"> em Regras Específicas para SciELO Brasil. #869

Merged
merged 5 commits into from
Oct 30, 2019

Conversation

jenniferamato
Copy link
Contributor

@jenniferamato jenniferamato commented Oct 22, 2019

O que esse PR faz?

Acrescenta a obrigatoriedade de <contrib-id contrib-id-type="orcid"> em Regras Específicas para SciELO Brasil.

Onde a revisão poderia começar?

Após elemento <product>
Acrescentado nota informando que para Errata e Retratação o elemento não é obrigatório, já que errata e retratação não terá autoria.

Quais são tickets relevantes?

#634

Copy link
Collaborator

@gustavofonseca gustavofonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reparei em um pequeno problema de lógica somente agora. Verifique, por gentileza, se faz sentido.

docs/source/narr/scielo-brasil.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@francine-curivil francine-curivil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concordo com a alteração.

@robertatakenaka robertatakenaka changed the title Fixes #634 Acrescenta a obrigatoriedade de <contrib-id contrib-id-type="orcid"> em Regras Específicas para SciELO Brasil. Oct 30, 2019
Copy link
Collaborator

@gustavofonseca gustavofonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excelente ;)

@gustavofonseca gustavofonseca merged commit e75305f into scieloorg:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants