New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate solr queries for members, reduces load times for large works #698

Merged
merged 1 commit into from Jul 17, 2017

Conversation

Projects
None yet
2 participants
@hackmastera
Contributor

hackmastera commented Jul 14, 2017

No description provided.

end
end
end

This comment has been minimized.

@jrochkind

jrochkind Jul 17, 2017

Contributor

I am not a fan of the member_presenters override, I expect fragility, but I agree this is the right approach if the base code wasn't doing it all in one solr query and this makes it do so. :(

@jrochkind

jrochkind Jul 17, 2017

Contributor

I am not a fan of the member_presenters override, I expect fragility, but I agree this is the right approach if the base code wasn't doing it all in one solr query and this makes it do so. :(

This comment has been minimized.

@jrochkind

jrochkind Jul 17, 2017

Contributor

It's kind of ridiculous this isn't the default behavior.

@jrochkind

jrochkind Jul 17, 2017

Contributor

It's kind of ridiculous this isn't the default behavior.

This comment has been minimized.

@hackmastera

hackmastera Jul 17, 2017

Contributor

Yeah, a contribution back to hyrax was requested while discussing on slack

@hackmastera

hackmastera Jul 17, 2017

Contributor

Yeah, a contribution back to hyrax was requested while discussing on slack

@jrochkind jrochkind merged commit 97f79c0 into master Jul 17, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jrochkind jrochkind deleted the efficient-member-presenter branch Jul 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment