Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
inline rights_statement in _chf_download_menu #723
This did have significant perf impact.
Turning it into a helper instead of a partial had the same perf impact, if we wanted to keep DRY.
But I think this was a false DRY in the first place, it really IS a
Note that all the actual heavy-lifting is done by calls to
This does make me consider turning the OTHER two partials into helper
Jul 21, 2017
@hackmastera yes, I think you're right, I just didn't get to thinking about it, was focusing on the perf goal.
I thought I saw commits where you doing that in the github history, but this is merged without it -- I've gotten confused as to what's going on with the various PR's, can you give me an update? :)