New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid calling representative_presenter for each child work on a parent show page #731

Merged
merged 1 commit into from Jul 25, 2017

Conversation

Projects
None yet
2 participants
@jrochkind
Contributor

jrochkind commented Jul 24, 2017

It results in three trips to Solr and is too expensive.

To avoid it, we index the data we need directly on the work itself.

This does seem to significantly improve performance, and is probably the cause of
our last remaining perf problem crosses fingers.

I separately PR'd the indexing changes to master. I did them here too, which
might cause a conflict on merge, but since the GenericWorkIndexer changes
paths between the branches, I was worried it might end up lost entirely
and not properly merged without a conflcit, I'd rather a conflict so
we make sure it winds up here.

Avoid calling representative_presenter for each child work on a paren…
…t show page

It results in three trips to Solr and is too expensive.

To avoid it, we index the data we need directly on the work itself.

This does seem to significantly improve performance, and is probably the cause of
our last remaining perf problem crosses fingers.

I separately PR'd the indexing changes to master. I did them here too, which
might cause a conflict on merge, but since the GenericWorkIndexer changes
paths between the branches, I was worried it might end up lost entirely
and not properly merged without a conflcit, I'd rather a conflict so
we make sure it winds up here.

@hackmastera hackmastera merged commit 6c756d1 into riiif Jul 25, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@hackmastera hackmastera deleted the riiif_avoid_representative_presenter branch Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment