Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Improvement: Prevent lighthouse failure from blocking the deploy preview #260

Closed
rossbar opened this issue Jul 10, 2022 · 2 comments
Closed

CI Improvement: Prevent lighthouse failure from blocking the deploy preview #260

rossbar opened this issue Jul 10, 2022 · 2 comments

Comments

@rossbar
Copy link
Member

rossbar commented Jul 10, 2022

I recently ran into an issue where I was getting intermittent/arbitrary failures in the "performance" metric from lighthouse. The problem with this is that lighthouse failures cause the entire netlify CI run to fail, which prevents the preview from deploying (AFAICT). I think it'd be an improvement if lighthouse failures could be treated as non-blocking; i.e. have the site preview still deploy when the build is successful, even if lighthouse fails.
@jarrodmillman
Copy link
Member

This started recently and I am not sure why the performance metric has been so inconsistent. I am looking into it and will let you know what I find. (I've only noticed it happening on PRs. I haven't seen it happen when a PR is merged into main.)

@jarrodmillman
Copy link
Member

I was able to upgrade it to 3.0.1 (see #269). I have some follow-up still to do, but hopefully the PR noise will be gone now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jarrodmillman @rossbar