Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make automated regression tests for each supported reader and writer #85

Open
hinerm opened this issue Oct 25, 2013 · 6 comments
Open
Assignees
Milestone

Comments

@hinerm
Copy link
Member

hinerm commented Oct 25, 2013

I severely broke writing with the N-D conversion in 0.7.0, and didn't catch it. It is too much of a burden to manually test the combinations of reading, writing and translation, but these are critical things to have test coverage over.

So we need to establish a pixel-based test like the test-images-good tests in Bio-Formats, and I don't think we should release 0.8.0 without it.

@hinerm
Copy link
Member Author

hinerm commented Oct 25, 2013

  • first pass test:
  • create a variety of fakes
  • Write them using each writer
  • read them back with each reader
  • port the Bio-Formats test-suite component to scifio, make maven run on every compile against fakes

@hinerm
Copy link
Member Author

hinerm commented Oct 25, 2013

the comprehensive tests will be running the test suite against a scifio-compatible subset of test-images-good

@hinerm
Copy link
Member Author

hinerm commented Feb 3, 2014

So we need to establish a pixel-based test like the test-images-good tests in Bio-Formats, and I
don't think we should release 0.8.0 without it.

Just kidding, this should be a priority for the remainder of 0.9.0. With a variety of breaking structural changes (e.g. SCIFIOConfig, restructuring to remove protected fields, writer initialization restructuring) it would be nice to have some peace of mind that significant parts of the framework are not being hosed, without resorting to manual testing.

@hinerm
Copy link
Member Author

hinerm commented Feb 4, 2014

Should focus on porting the bio-formats testing framework. Also, it would be good to make these tests publicly reproducible by providing either a new repo or using git-annex to make at least 1 dataset for each supported format available.

@hinerm hinerm modified the milestones: 0.10.0, 0.9.0 Feb 11, 2014
@hinerm hinerm modified the milestones: 0.11.0, 0.10.0 Mar 10, 2014
@hinerm hinerm modified the milestones: 0.12.0, 0.11.0 Apr 21, 2014
@hinerm hinerm modified the milestones: 0.13.0, 0.12.0, 0.15.0 May 30, 2014
@hinerm hinerm modified the milestones: 0.16.0, 0.15.0 Jun 10, 2014
@hinerm
Copy link
Member Author

hinerm commented Sep 19, 2014

After discussion with @dietzc it seems like we should be able to do this easily with KNIME. Hooray!

@hinerm hinerm removed this from the 0.16.0 milestone Mar 10, 2015
@hinerm hinerm self-assigned this Mar 11, 2015
@hinerm hinerm added this to the m2 milestone Mar 11, 2015
@ctrueden ctrueden self-assigned this Nov 14, 2018
@ctrueden ctrueden added the to do label Nov 14, 2018
@ctrueden
Copy link
Member

ctrueden commented Nov 14, 2018

Here is the current plan, as discussed on Gitter:

  • @ctrueden Create samples.scif.io to host ZIP files of all sample data we are able to license under CC0.
  • @ctrueden Update scif.io main website to have a "Sample Data" section, initially populated from the LOCI sample datasets, linking to samples.scif.io.
  • @gab1one Make a list of still-needed samples for good test coverage. This will not be a full "SCIFIO supported formats" table.
  • @gab1one Implement base logic in src/test/java for downloading and unpacking requested ZIPs from samples.scif.io, similar to this logic, and then reading the unpacked file(s), validating against known expected pixels & metadata values. (Consider the DRYest way to achieve this validation thoroughly. For metadata, my idea is to externalize the metadata using SCIFIO, and keep it along side the ZIPs, then verify that reparsed metadata matches the externalized information.)
  • @gab1one Use the base logic in each format's regression tests to validate reading of real files.
  • @ctrueden Once all is working, delete https://github.com/scifio/scifio-testing since it will no longer be necessary as a separate repository. Each repository's Format plugins should have corresponding tests leveraging the framework described above.

gab1one added a commit that referenced this issue Nov 20, 2018
gab1one added a commit that referenced this issue Nov 20, 2018
gab1one added a commit that referenced this issue Dec 9, 2018
- Currently points to local zips, need to point to remote ones!
hinerm added a commit that referenced this issue Oct 29, 2021
It runs in ~6s in Eclipse but took an extra minute from the command
line. I'd prefer to put it in an integration suite, maybe as part of #85
hinerm added a commit that referenced this issue Nov 10, 2021
It runs in ~6s in Eclipse but took an extra minute from the command
line. I'd prefer to put it in an integration suite, maybe as part of #85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants