Script String parameters are not harvested in Java 8

[imagejan]

I just tried to setup a python script in Fiji using

# @String name

and discovered that it doesn't work as before: Now an error message is shown:

'name' is required but unset.

I tried with any of the "Greeting" templates of the Fiji script editor (Groovy, Javascript, Python, Ruby).
Any idea what has changed?

[imagejan]

Sorry, just noticed that this only happens when running Fiji with Java 8 (on Windows).

[ctrueden]

Is your Fiji fully up-to-date? I cannot reproduce on OS X.

Does it happen with non-String parameters? I am guessing that Templates > JavaScript > Widgets bombs horribly?

[imagejan]

I tried again, now it works with both Java 1.6.0 and Java 1.8.0 under Windows 7.
Sorry for the buzz, I don't know why it happened before.

[ctrueden]

@imagejan FWIW, you're not crazy—I have seen that error in the past too, mysteriously. It's been too long now, so I don't remember if I had to make a code change to resolve it, or if it was transient.

Definitely speak up if you see it again!

[imagejan]

@ctrueden I was able to reproduce this issue on Mac OSX 10.10.5 after cloning imagej-ui-swing, installing Eclipse (Mars), importing the cloned project, running ScriptEditorTestDrive.java from within Eclipse, and opening and running one of the JavaScript templates.
Is it actually supposed to work from within Eclipse? The dependencies look ok to me, but do I have the SciJavaServices when running in Eclipse? Pardon my ignorance.

[ctrueden]

I tried running ScriptEditorTestDrive using the latest master of imagej-ui-swing on my OS X 10.5.5 system, and was unable to reproduce the 'name' is required but unset. behavior, although it does not work as intended either. In my case, it simply does nothing. No dialog box, no output greeting, but also no error.

It is the end of the day here and I don't have time to debug it now, but that's what would be required to solve it: running in debug mode and digging in to the preprocessors.

What should be happening is that the SwingInputHarvester (from the scijava-ui-swing component) should be noticing that there is a String input parameter, and building a dialog to prompt for it.

do I have the SciJavaServices when running in Eclipse?

In short, yes. But it all depends what is on the classpath at runtime, of course. In the case of imagej-ui-swing: we have scijava-ui-swing, scijava-common and scripting-javascript all on the classpath, which contain all the needed bits to make this example work, at least in theory.

[ctrueden]

Reopening until we get to the bottom of this...

[imagejan]

One possible cause of this might be ij.plugin.frame.MemoryMonitor competing with the parameter harvesting, see #241

[ctrueden]

I can't reproduce this on macOS nor Windows with an up-to-date Fiji. So I'm going to close this again. See also #241 (comment). But if it crops again, please feel free to reopen. We might need to debug it directly on the system where it's failing, though.