ScriptHeader auto-generation #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ctrueden @dscho if you get a chance could you take a quick look? See also:
for my current planned implementation. |
|
Thanks for doing that, Mark. I wrote some comments. We can merge tomorrow after those are addressed. |
|
I really like the general direction! |
Create a new ScriptHeaderService, a handler of a new ScriptHeader plugin type. The purpose of this new framework is to allow flexible addition of header text to scripts, specified by language.
hinerm
force-pushed
the
script-header-service
branch
from
54bc7fc to
b00d3ba
Compare
Pointed out by ctrueden: string concatenation has been showed to have significant overhead in time and space, thus we should be using StringBuilder. This also removes the potential for a null header value.
|
@ctrueden this time I think I actually addressed all your points.. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new service and plugin type for language-specific automatic populate of script headers.