Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict Ops to single output #19

Merged
merged 1 commit into from Jun 19, 2019

Conversation

Projects
None yet
2 participants
@MarcelWiedenmann
Copy link
Contributor

commented Jun 14, 2019

This PR removes the support for secondary Op outputs. Both OpRef and OpInfo only specify single outputs from now on. Op matching and transformation are adapted accordingly. Also, validation is added to enforce this new constraint during Op discovery and Op dependency resolution.

@ctrueden
Copy link
Member

left a comment

Nice! Just one small thing I noticed.

i++;
}
final Type outputType = candidate.getRef().getOutType();
if (Objects.equal(outputType, OpUtils.outputType(candidate)))

This comment has been minimized.

Copy link
@ctrueden

ctrueden Jun 14, 2019

Member

Do you need the Guava Objects.equal here, rather than the standard Java library's Objects?

This comment has been minimized.

Copy link
@MarcelWiedenmann

MarcelWiedenmann Jun 14, 2019

Author Contributor

Woops, nope, that probably was an auto-import fail. Good catch - thanks!
Edit: or rather a misstyped equal vs equals. Fixed it.

Restrict Ops to single output
This commit removes the support for secondary Op outputs. Both OpRef
and OpInfo only specify single outputs from now on. Op matching and
transformation are adapted accordingly. Also, validation is added to
enforce this new constraint during Op discovery.

@MarcelWiedenmann MarcelWiedenmann force-pushed the single-op-output branch from 3fe607a to c107500 Jun 14, 2019

@ctrueden ctrueden merged commit 2de39c7 into master Jun 19, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@ctrueden ctrueden deleted the single-op-output branch Jun 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.