Support GitHub 2-factor authentication #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@dscho: If your superior script-fu can fix the ugliness, great, but I couldn't get anything simpler than this working in a reasonable amount of time. |
... in preparation for two-factor authentication... Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
GitHub requires a special header when two-factor authentication is enabled. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Contributor
|
@ctrueden could you give this version a quick try? |
Member
Author
|
It works! Thank you for fixing it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works by passing the auth code via the
GITHUB_TWO_FACTORenvironment variable.Unfortunately, the patch is really ugly. I tried assigning the header flags to CURL_OPTS and just passing that, but the quoting is really hard to get right. This patch is testing and working for 2-factor, at least.