Skip to content

Conversation

imagejan
Copy link
Member

@imagejan imagejan commented Apr 8, 2015

This is my take on fixing issue #7

@ctrueden
Copy link
Member

ctrueden commented Apr 8, 2015

Thanks! Unfortunately, in my tests, there are a couple of problems:

  • The console does not quite scroll to the very bottom.
  • The console jumps to the bottom regardless of the position of the scroll bar. Better would be to only keep things scrolled to the bottom if the scroll bar is already at the bottom. This is how most popular terminal applications work.

I pushed an alternative fix: ad58bd7
Which uses new utility methods: a6d8604

@ctrueden ctrueden closed this Apr 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants