Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ij1macro autocompletion #21

Conversation

@haesleinhuepf
Copy link
Member

haesleinhuepf commented Jun 25, 2018

Hey guys,

as discussed on the forum. This PR brings auto completion for IJ macro.
http://forum.imagej.net/t/auto-code-completion-for-ij-macro/11642

Please let me know what you think.

Cheers,
Robert

@imagejan

This comment has been minimized.

Can we use the recommended imagej.net domain here, please?

https://imagej.net/developer/macro/functions.html#

imagej.nih.gov turned out to be very unreliable in the past with https.

@imagejan

This comment has been minimized.

Copy link

imagejan commented on 8c28842 Jun 25, 2018

How can we make sure that the functions.html bundled here reflects the latest state of https://imagej.net/developer/macro/functions.html ? Can we rely on the online version and allow optional caching, similar to how it is done for the sample images (i.e. File > Open Samples > Cache Sample Images)?

…rnet is accessible, otherwise take the file from resources dir
@haesleinhuepf

This comment has been minimized.

Copy link
Member Author

haesleinhuepf commented Jun 25, 2018

The URL was changed with 1820568

Furthermore, I implemented a web-first strategy downloading functions.html from imagej.net if available. And there is a fallback to the functions.html in the resources dir. a95e06a

I don't like it so much as it takes a second to switch to macro language, because the internet is asked for the file... We may think about this...

@ctrueden

This comment has been minimized.

Copy link
Member

ctrueden commented Jun 25, 2018

This is awesome—thanks for working on it, @haesleinhuepf.

I am cleaning up the patch series now. The new language support plugin needs to live in imagej-legacy. The cleanups to the script-editor should stay here, of course. New PRs coming in a bit.

@ctrueden

This comment has been minimized.

Copy link
Member

ctrueden commented Jun 25, 2018

Closed in favor of #22 and imagej/imagej-legacy#191.

@ctrueden ctrueden closed this Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.