From d70fd519db37f4b1a92eaeced5e9bba0308142a0 Mon Sep 17 00:00:00 2001 From: 0xTowel <0xTowel@users.noreply.github.com> Date: Fri, 20 Oct 2023 09:38:40 -0700 Subject: [PATCH 1/2] Fix bad config option name in configuration.md The system platform is referenced as `platform_system` in the toml, not `sys.platform`. It is still computed by `sys.platform` however. --- docs/configuration.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/configuration.md b/docs/configuration.md index b81bd492a..c3806df05 100644 --- a/docs/configuration.md +++ b/docs/configuration.md @@ -584,7 +584,7 @@ specify a `tool.scikit-build.overrides` array with an `if` key. That if key can take several values, based on [PEP 508][]: - `python_version`: The two-digit Python version. Takes a specifier set. -- `sys_platform`: The value of `sys.platform`. Takes a regex. +- `platform_system`: The value of `sys.platform`. Takes a regex. - `platform_machine`: The value of `platform.machine()`. Takes a regex. - `platform_node`: The value of `platform.node()`. Takes a regex. - `implementation_name`: The value of `sys.implementation.name`. Takes a regex. From dd05548ae99aea62777009c97aea6a8c9265650b Mon Sep 17 00:00:00 2001 From: Henry Schreiner Date: Tue, 31 Oct 2023 09:12:13 -0400 Subject: [PATCH 2/2] Update configuration.md --- docs/configuration.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/configuration.md b/docs/configuration.md index c3806df05..9322ca81f 100644 --- a/docs/configuration.md +++ b/docs/configuration.md @@ -583,12 +583,12 @@ Scikit-build-core has an override system, similar to cibuildwheel and mypy. You specify a `tool.scikit-build.overrides` array with an `if` key. That if key can take several values, based on [PEP 508][]: -- `python_version`: The two-digit Python version. Takes a specifier set. -- `platform_system`: The value of `sys.platform`. Takes a regex. -- `platform_machine`: The value of `platform.machine()`. Takes a regex. -- `platform_node`: The value of `platform.node()`. Takes a regex. -- `implementation_name`: The value of `sys.implementation.name`. Takes a regex. -- `implementation_version`: Derived from `sys.implementation.version`, following +- `python-version`: The two-digit Python version. Takes a specifier set. +- `platform-system`: The value of `sys.platform`. Takes a regex. +- `platform-machine`: The value of `platform.machine()`. Takes a regex. +- `platform-node`: The value of `platform.node()`. Takes a regex. +- `implementation-name`: The value of `sys.implementation.name`. Takes a regex. +- `implementation-version`: Derived from `sys.implementation.version`, following PEP 508. Takes a specifier set. At least one must be provided. Then you can specify any collection of valid @@ -597,7 +597,7 @@ will match top to bottom, overriding previous matches. For example: ```toml [[tool.scikit-build.overrides]] -if.sys_platform = "darwin" +if.sys-platform = "darwin" cmake.minimum-version = "3.18" ```