Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated wheels do not have a platform specfied #106

Closed
thewtex opened this issue Jul 25, 2016 · 4 comments
Closed

Generated wheels do not have a platform specfied #106

thewtex opened this issue Jul 25, 2016 · 4 comments
Assignees
@jcfr
Labels
Type: Bug Something's not working correctly.
Milestone
0.4.0

Comments

@thewtex
Copy link
Member

thewtex commented Jul 25, 2016

This is evident in the wheel file name (``none-any) and in the METADATA file _Platform_ entry, which is currently UNKNOWN`.
@thewtex thewtex added the Type: Bug Something's not working correctly. label Jul 25, 2016
@jcfr jcfr added this to the 0.2.0 milestone Jul 25, 2016
@thewtex thewtex mentioned this issue Aug 10, 2016
Open
8 tasks
@jcfr
Copy link
Contributor

jcfr commented Aug 19, 2016

package_data have been abused to integrate the binary artefacts into the "wheel", there are few possible hacks:

  • inject the platform info after the fact
    or
  • create an Extension class responsible to invoke CMake and collect the artefacts

@jcfr jcfr changed the title Generated wheels do not have an platform specfied Generated wheels do not have a platform specfied Aug 23, 2016
@jcfr
Copy link
Contributor

jcfr commented Aug 26, 2016

See https://github.com/SimpleITK/SimpleITK/blob/master/Wrapping/Python/Packaging/setup.py.in#L47-L56

@jcfr
Copy link
Contributor

jcfr commented Aug 26, 2016

See https://github.com/espdev/ITKPythonInstaller/blob/e698360e89f12d417431798f2d3117aff870cb26/setup.py.in#L31-L36

jcfr added a commit that referenced this issue Aug 29, 2016
@jcfr
setuptools_wrap: Force binary wheel generation. Fixes #106
689078e 
Hack adapted from https://github.com/espdev/ITKPythonInstaller
@jcfr jcfr assigned jcfr and unassigned opadron Aug 29, 2016
@jcfr jcfr closed this as completed in e9cc6fb Aug 31, 2016
jcfr added a commit that referenced this issue Aug 31, 2016
@jcfr
Merge pull request #128 from scikit-build/106-fix-wheel-generation
49b628a 
setuptools_wrap: Force binary wheel generation. Fixes #106
@thewtex
Copy link
Member Author

thewtex commented Aug 31, 2016

Cool :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcfr jcfr

Labels
Type: Bug Something's not working correctly.
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
3 participants
@thewtex @jcfr @opadron