/scikit-build

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated wheels do not have a platform specfied #106

Closed
thewtex opened this Issue Jul 25, 2016 · 4 comments

Comments

Assignees

@jcfr jcfr

Labels
bug
Milestone
  0.4.0
3 participants
@thewtex @jcfr @opadron
@thewtex
Member

thewtex commented Jul 25, 2016

This is evident in the wheel file name (``none-any) and in the METADATA file _Platform_ entry, which is currently UNKNOWN`.

@thewtex thewtex added the bug label Jul 25, 2016

@thewtex thewtex assigned opadron Jul 25, 2016

@jcfr jcfr added this to the 0.2.0 milestone Jul 25, 2016

@thewtex thewtex referenced this issue Aug 10, 2016

Open

Implement as PEP 517 build backend interface, configured with pyproject.toml and CMakeLists.txt #124

0 of 8 tasks complete
@jcfr

This comment has been minimized.

Sign in to view
Contributor

jcfr commented Aug 19, 2016

package_data have been abused to integrate the binary artefacts into the "wheel", there are few possible hacks:

  • inject the platform info after the fact
    or
  • create an Extension class responsible to invoke CMake and collect the artefacts

@jcfr jcfr changed the title from Generated wheels do not have an platform specfied to Generated wheels do not have a platform specfied Aug 23, 2016

@jcfr

This comment has been minimized.

Sign in to view
Contributor

jcfr commented Aug 26, 2016

See https://github.com/SimpleITK/SimpleITK/blob/master/Wrapping/Python/Packaging/setup.py.in#L47-L56
@jcfr

jcfr added a commit that referenced this issue Aug 29, 2016

@jcfr
setuptools_wrap: Force binary wheel generation. Fixes #106 
Hack adapted from https://github.com/espdev/ITKPythonInstaller
Loading status checks…
689078e

@jcfr jcfr assigned jcfr and unassigned opadron Aug 29, 2016

@jcfr jcfr closed this in e9cc6fb Aug 31, 2016

jcfr added a commit that referenced this issue Aug 31, 2016

@jcfr
Merge pull request #128 from scikit-build/106-fix-wheel-generation 
setuptools_wrap: Force binary wheel generation. Fixes #106
Loading status checks…
49b628a
@thewtex

This comment has been minimized.

Sign in to view
Member

thewtex commented Aug 31, 2016

Cool :-)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment