New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated wheels do not have a platform specfied #106

Closed
thewtex opened this Issue Jul 25, 2016 · 4 comments

Comments

3 participants
@thewtex
Member

thewtex commented Jul 25, 2016

This is evident in the wheel file name (``none-any) and in the METADATA file _Platform_ entry, which is currently UNKNOWN`.

@jcfr

This comment has been minimized.

Contributor

jcfr commented Aug 19, 2016

package_data have been abused to integrate the binary artefacts into the "wheel", there are few possible hacks:

  • inject the platform info after the fact
    or
  • create an Extension class responsible to invoke CMake and collect the artefacts

@jcfr jcfr changed the title from Generated wheels do not have an platform specfied to Generated wheels do not have a platform specfied Aug 23, 2016

@jcfr

This comment has been minimized.

jcfr added a commit that referenced this issue Aug 29, 2016

@jcfr jcfr assigned jcfr and unassigned opadron Aug 29, 2016

@jcfr jcfr closed this in e9cc6fb Aug 31, 2016

jcfr added a commit that referenced this issue Aug 31, 2016

Merge pull request #128 from scikit-build/106-fix-wheel-generation
setuptools_wrap: Force binary wheel generation. Fixes #106
@thewtex

This comment has been minimized.

Member

thewtex commented Aug 31, 2016

Cool :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment