Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WHEEL file: Mention scikit-build in Generator field #191

Closed
jcfr opened this issue Sep 25, 2016 · 0 comments
Closed

WHEEL file: Mention scikit-build in Generator field #191

jcfr opened this issue Sep 25, 2016 · 0 comments

Comments

@jcfr
Copy link
Contributor

@jcfr jcfr commented Sep 25, 2016

Instead of

Wheel-Version: 1.0
Generator: bdist_wheel (0.29.0)
Root-Is-Purelib: false
Tag: cp27-cp27mu-linux_x86_64

we could have

Wheel-Version: 1.0
Generator: skbuild.command.bdist_wheel (0.3.0)
Root-Is-Purelib: false
Tag: cp27-cp27mu-linux_x86_64

In section file-contents, the PEP-0427 mentions the following:

[...]

8. Generator is the name and optionally the version of the software that produced the archive.

[...]

Implementation of bdist_wheel is in

https://bitbucket.org/pypa/wheel/src/54ddbcc9cec25e1f4d111a142b8bfaa163130a61/wheel/bdist_wheel.py?at=default&fileviewer=file-view-default#bdist_wheel.py-260:265

[...]

    def write_wheelfile(self, wheelfile_base, generator='bdist_wheel (' + wheel_version + ')'):
        from email.message import Message
        msg = Message()
        msg['Wheel-Version'] = '1.0'  # of the spec
        msg['Generator'] = generator
        msg['Root-Is-Purelib'] = str(self.root_is_pure).lower()
[...]

Otherwise, here is what other tools are doing:

[...]
wheel_file_template = """\
Wheel-Version: 1.0
Generator: flit {version}
Root-Is-Purelib: true
""".format(version=__version__)
[...]
???
???
@jcfr jcfr added this to the 0.5.0 milestone Sep 25, 2016
jcfr added a commit that referenced this issue Dec 20, 2016
Fixes #191
jcfr added a commit that referenced this issue Dec 20, 2016
Fixes #191
jcfr added a commit that referenced this issue Dec 20, 2016
Fixes #191
jcfr added a commit that referenced this issue Dec 20, 2016
Fixes #191
jcfr added a commit that referenced this issue Dec 20, 2016
Fixes #191
jcfr added a commit that referenced this issue Feb 22, 2018
Fixes #191
jcfr added a commit that referenced this issue Feb 22, 2018
Fixes #191
@jcfr jcfr closed this in #236 Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant