Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skbuild/resources is not in MANIFEST.in #214

Closed
isuruf opened this issue Nov 23, 2016 · 1 comment
Closed

skbuild/resources is not in MANIFEST.in #214

isuruf opened this issue Nov 23, 2016 · 1 comment
Labels
Type: Bug Something's not working correctly.

Comments

@isuruf
Copy link
Contributor

isuruf commented Nov 23, 2016

Source distribution in PyPI does not have the cmake files because of this
@jcfr
Copy link
Contributor

jcfr commented Nov 23, 2016

Good catch. We should implement test for the sdist.

On Nov 23, 2016 1:11 PM, "Isuru Fernando" notifications@github.com wrote:

Source distribution in PyPI does not have the cmake files because of this

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#214, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AANXo-iXQUQgcyCPBcn9KH57ySedwsqkks5rBIHegaJpZM4K65eK
.

jcfr added a commit that referenced this issue Nov 24, 2016
@jcfr
Update MANIFEST.in to fix use of sdist adding missing CMake modules.
e62da60 
Fix #214

Reported-by: Isuru Fernando <isuruf@gmail.com>
jcfr added a commit that referenced this issue Nov 24, 2016
@jcfr
tests: Add test_distribution. See #214
60a2f61
jcfr added a commit that referenced this issue Dec 1, 2016
@jcfr
tests: Add test_distribution. See #214
b207bbd
jcfr added a commit that referenced this issue Dec 1, 2016
@jcfr
changelog: Add reference to the "source distribution" fix. See #214
d55dcc0
@jcfr jcfr closed this as completed in 6840257 Dec 2, 2016
@jcfr jcfr added the Type: Bug Something's not working correctly. label May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Something's not working correctly.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcfr @isuruf