New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skbuild/resources is not in MANIFEST.in #214

Closed
isuruf opened this Issue Nov 23, 2016 · 1 comment

Comments

2 participants
@isuruf

isuruf commented Nov 23, 2016

Source distribution in PyPI does not have the cmake files because of this

@jcfr

This comment has been minimized.

Contributor

jcfr commented Nov 23, 2016

Good catch. We should implement test for the sdist.

On Nov 23, 2016 1:11 PM, "Isuru Fernando" notifications@github.com wrote:

Source distribution in PyPI does not have the cmake files because of this


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#214, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AANXo-iXQUQgcyCPBcn9KH57ySedwsqkks5rBIHegaJpZM4K65eK
.

jcfr added a commit that referenced this issue Nov 24, 2016

Update MANIFEST.in to fix use of sdist adding missing CMake modules.
Fix #214

Reported-by: Isuru Fernando <isuruf@gmail.com>

jcfr added a commit that referenced this issue Nov 24, 2016

jcfr added a commit that referenced this issue Dec 1, 2016

jcfr added a commit that referenced this issue Dec 1, 2016

@jcfr jcfr closed this in 6840257 Dec 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment