New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install fails when package_dir = {'':'src'} #274

Closed
benjaminjack opened this Issue Jan 28, 2018 · 5 comments

Comments

3 participants
@benjaminjack

benjaminjack commented Jan 28, 2018

I have a package structure that looks like this:

├─ src
│  └─ packagename
│     ├─ __init__.py
│     └─ ...
├─ tests
│  └─ ...
├─ CMakeLists.txt
└─ setup.py

My setup.py script looks like this:

setup(
    ...
    packages=find_packages('src'),
    package_dir={'': 'src'},
    ...
)

Running pip install . and pip install -e . fails with an error saying that directory 'package_name' cannot be found. Running the same commands with setuptools setup works fine.

jcfr added a commit that referenced this issue Feb 21, 2018

setuptools_wrap: Add support for default package_dir
This commit supports specifying a default directory for all packages
that do not have one already explicitly associated with them.

See #274

jcfr added a commit that referenced this issue Feb 21, 2018

setuptools_wrap: Add support for default package_dir
This commit supports specifying a default directory for all packages
that do not have one already explicitly associated with them.

See #274

jcfr added a commit that referenced this issue Feb 21, 2018

setuptools_wrap: Add support for default package_dir
This commit supports specifying a default directory for all packages
that do not have one already explicitly associated with them.

See #274

jcfr added a commit that referenced this issue Feb 21, 2018

setuptools_wrap: Add support for default package_dir
This commit supports specifying a default directory for all packages
that do not have one already explicitly associated with them.

See #274

jcfr added a commit that referenced this issue Feb 22, 2018

setuptools_wrap: Add support for default package_dir
This commit supports specifying a default directory for all packages
that do not have one already explicitly associated with them.

See #274

@jcfr jcfr added the bug label Feb 22, 2018

@jcfr

This comment has been minimized.

Contributor

jcfr commented Feb 22, 2018

@benjaminjack Thanks for the report 👍

This should be fixed by #296

Once the PR is integrated and new release of scikit-build published on pypi, you should be able to also update benjaminjack/python_cpp_example project by integrating benjaminjack/python_cpp_example#1

jcfr added a commit that referenced this issue Feb 22, 2018

setuptools_wrap: Add support for default package_dir
This commit supports specifying a default directory for all packages
that do not have one already explicitly associated with them.

See #274
@jcfr

This comment has been minimized.

Contributor

jcfr commented Feb 22, 2018

Closing. Fixed integrated in 3f5cfc6

@jcfr jcfr closed this Feb 22, 2018

@anthrotype

This comment has been minimized.

anthrotype commented Mar 18, 2018

@jcfr thanks for fixing this! I also use the same package layout.
I see this is fixed on master, but not yet on the current version which is on PyPI.
Do you have an estimate when the next version will be released and uploaded to PyPI?
I know I can pip install directly from the github repo for the time being, but still would be nice to have it on PyPI as well.
Thank you

anthrotype added a commit to trufont/uharfbuzz that referenced this issue Mar 18, 2018

add requirements-dev.txt with build requirements
we install scikit-build from the git repository instead of PyPI because of
scikit-build/scikit-build#274 (comment)
@anthrotype

This comment has been minimized.

anthrotype commented Apr 19, 2018

@jcfr I'd love to have the latest scikit-build wheel released on PyPI, so I can use it with the new pyproject.toml 🙏

@jcfr

This comment has been minimized.

Contributor

jcfr commented Jun 30, 2018

Good news. A new release will be pushed any day !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment