New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pyproject.toml in Pip 10 #312

Open
henryiii opened this Issue Apr 2, 2018 · 5 comments

Comments

3 participants
@henryiii
Contributor

henryiii commented Apr 2, 2018

Pip 10.0.0b1 was released, with support for pyproject.toml. This allows a project to specify that it needs scikit-build in the setup phase, allowing for the first time a simple "pip install package" for a scikit-build package. pyproject.tomls should be added to the examples in tests and documentation.

On a related note, cmake could be added as a dependency as well, but since a user may have cmake, that's probably better in setup_requires or maybe not at all. If scikit-build could gain a new require_cmake_version argument, which would then check for the cmake command and ask it's version, then add the python 'cmake' as a requirement if this does not pass, that might be ideal.

@henryiii

This comment has been minimized.

Contributor

henryiii commented Apr 2, 2018

@jcfr jcfr self-assigned this May 28, 2018

@jcfr

This comment has been minimized.

Contributor

jcfr commented Jul 4, 2018

xref #313

jcfr added a commit that referenced this issue Jul 8, 2018

jcfr added a commit that referenced this issue Jul 8, 2018

@jcfr

This comment has been minimized.

Contributor

jcfr commented Jul 9, 2018

@thewtex

This comment has been minimized.

Member

thewtex commented Jul 16, 2018

@jcfr we can close this?

@jcfr

This comment has been minimized.

Contributor

jcfr commented Jul 16, 2018

Not yet:

  • add test using pyproject.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment