/scikit-build

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support setting cmake_source_dir to a relative parent directory #335

Closed
jcfr opened this Issue Jul 14, 2018 · 1 comment

Comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
1 participant
@jcfr
@jcfr
Contributor

jcfr commented Jul 14, 2018

No description provided.

jcfr added a commit to jcfr/replicate_pytime_timeval_error that referenced this issue Jul 14, 2018

@jcfr
setup: build package from subdirectory 
This is currently failing. See scikit-build/scikit-build#335
Verified
This commit was signed with a verified signature.
@jcfr jcfr Jean-Christophe Fillion-Robin
GPG key ID: BAF1E1AEB9097A41 Learn about signing commits
a87c96f

massich added a commit to massich/scikit-build that referenced this issue Jul 14, 2018

@massich
Add a breaking test for issue scikit-build#335
88e0b36

@massich massich referenced this issue Jul 14, 2018

Merged

Add support for cmake_source_dir #337

massich added a commit to massich/scikit-build that referenced this issue Jul 14, 2018

@massich
Add a breaking test for issue scikit-build#335
ad07725

massich added a commit to massich/scikit-build that referenced this issue Jul 14, 2018

@massich
Add a breaking test for issue scikit-build#335
04f346b

massich added a commit to massich/scikit-build that referenced this issue Jul 14, 2018

@massich
Add a breaking test for issue scikit-build#335
bdc52fb
@jcfr

This comment has been minimized.

Sign in to view
Contributor

jcfr commented Jul 14, 2018

@massich Here is the commit message that could be associated with the removal of this code:

setuptools_wrap: Fix handling of relative parent cmake source dir

This commit fixes the case where `cmake_source_dir` is set to a relative directory
outside of the `setup.py` directory. It does so by removing code originally introduced
in 0d0ddbf (setuptools_wrap: Add support for "cmake" and "hybrid" python package)
that was never covered by tests.

Fixes #335

massich added a commit to massich/scikit-build that referenced this issue Jul 14, 2018

@massich
Add a breaking test for issue scikit-build#335
0a4be2d

massich added a commit to massich/scikit-build that referenced this issue Jul 14, 2018

@massich
setuptools_wrap: Fix handling of relative parent cmake source dir 
This commit fixes the case where `cmake_source_dir` is set to a relative
directory outside of the `setup.py` directory (i.e `${cmake_source_dir}\some\dirs\setup.py`)

The fix is done by removing code originally introduced in 0d0ddbf
(setuptools_wrap: Add support for "cmake" and "hybrid" python package)
that was never covered by tests.

Fixes scikit-build#335
8265bd5

jcfr added a commit to massich/scikit-build that referenced this issue Jul 15, 2018

@massich @jcfr
Add a breaking test for issue scikit-build#335
Verified
This commit was signed with a verified signature.
@jcfr jcfr Jean-Christophe Fillion-Robin
GPG key ID: BAF1E1AEB9097A41 Learn about signing commits
d7e5ca6

jcfr added a commit to massich/scikit-build that referenced this issue Jul 15, 2018

@massich @jcfr
setuptools_wrap: Fix handling of relative parent cmake source dir 
This commit fixes the case where `cmake_source_dir` is set to a relative
directory outside of the `setup.py` directory (i.e `${cmake_source_dir}\some\dirs\setup.py`)

The fix is done by removing code originally introduced in 0d0ddbf
(setuptools_wrap: Add support for "cmake" and "hybrid" python package)
that was never covered by tests.

Fixes scikit-build#335
Verified
This commit was signed with a verified signature.
@jcfr jcfr Jean-Christophe Fillion-Robin
GPG key ID: BAF1E1AEB9097A41 Learn about signing commits
5e52d5c

jcfr added a commit to massich/scikit-build that referenced this issue Jul 15, 2018

@jcfr
CHANGES: Document fix and improvements related to scikit-build#335
Verified
This commit was signed with a verified signature.
@jcfr jcfr Jean-Christophe Fillion-Robin
GPG key ID: BAF1E1AEB9097A41 Learn about signing commits
1385689

@jcfr jcfr closed this in #337 Jul 15, 2018

@jcfr jcfr referenced this issue Jul 29, 2018

Closed

Improve error checking associated with cmake_source_dir skbuild.setup keyword #169

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment