New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support setting cmake_source_dir to a relative parent directory #335
Labels
Type: Feature Request
Request for a new feature
Comments
jcfr
added a commit
to jcfr/replicate_pytime_timeval_error
that referenced
this issue
Jul 14, 2018
This is currently failing. See scikit-build/scikit-build#335
massich
added a commit
to massich/scikit-build
that referenced
this issue
Jul 14, 2018
massich
added a commit
to massich/scikit-build
that referenced
this issue
Jul 14, 2018
massich
added a commit
to massich/scikit-build
that referenced
this issue
Jul 14, 2018
massich
added a commit
to massich/scikit-build
that referenced
this issue
Jul 14, 2018
@massich Here is the commit message that could be associated with the removal of this code:
|
massich
added a commit
to massich/scikit-build
that referenced
this issue
Jul 14, 2018
massich
added a commit
to massich/scikit-build
that referenced
this issue
Jul 14, 2018
This commit fixes the case where `cmake_source_dir` is set to a relative directory outside of the `setup.py` directory (i.e `${cmake_source_dir}\some\dirs\setup.py`) The fix is done by removing code originally introduced in 0d0ddbf (setuptools_wrap: Add support for "cmake" and "hybrid" python package) that was never covered by tests. Fixes scikit-build#335
jcfr
pushed a commit
to massich/scikit-build
that referenced
this issue
Jul 15, 2018
jcfr
pushed a commit
to massich/scikit-build
that referenced
this issue
Jul 15, 2018
This commit fixes the case where `cmake_source_dir` is set to a relative directory outside of the `setup.py` directory (i.e `${cmake_source_dir}\some\dirs\setup.py`) The fix is done by removing code originally introduced in 0d0ddbf (setuptools_wrap: Add support for "cmake" and "hybrid" python package) that was never covered by tests. Fixes scikit-build#335
jcfr
added a commit
to massich/scikit-build
that referenced
this issue
Jul 15, 2018
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: