Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support setting cmake_source_dir to a relative parent directory #335

Closed
jcfr opened this issue Jul 14, 2018 · 1 comment · Fixed by #337
Closed

support setting cmake_source_dir to a relative parent directory #335

jcfr opened this issue Jul 14, 2018 · 1 comment · Fixed by #337
Labels
Type: Feature Request Request for a new feature

Comments

@jcfr
Copy link
Contributor

jcfr commented Jul 14, 2018

No description provided.

jcfr added a commit to jcfr/replicate_pytime_timeval_error that referenced this issue Jul 14, 2018
@jcfr
setup: build package from subdirectory
a87c96f 
This is currently failing. See scikit-build/scikit-build#335
massich added a commit to massich/scikit-build that referenced this issue Jul 14, 2018
@massich
Add a breaking test for issue scikit-build#335
88e0b36
@massich massich mentioned this issue Jul 14, 2018
Merged
massich added a commit to massich/scikit-build that referenced this issue Jul 14, 2018
@massich
Add a breaking test for issue scikit-build#335
ad07725
massich added a commit to massich/scikit-build that referenced this issue Jul 14, 2018
@massich
Add a breaking test for issue scikit-build#335
04f346b
massich added a commit to massich/scikit-build that referenced this issue Jul 14, 2018
@massich
Add a breaking test for issue scikit-build#335
bdc52fb
@jcfr
Copy link
Contributor Author

jcfr commented Jul 14, 2018

@massich Here is the commit message that could be associated with the removal of this code:

setuptools_wrap: Fix handling of relative parent cmake source dir

This commit fixes the case where `cmake_source_dir` is set to a relative directory
outside of the `setup.py` directory. It does so by removing code originally introduced
in 0d0ddbf (setuptools_wrap: Add support for "cmake" and "hybrid" python package)
that was never covered by tests.

Fixes #335

massich added a commit to massich/scikit-build that referenced this issue Jul 14, 2018
@massich
Add a breaking test for issue scikit-build#335
0a4be2d
massich added a commit to massich/scikit-build that referenced this issue Jul 14, 2018
@massich
setuptools_wrap: Fix handling of relative parent cmake source dir
8265bd5 
This commit fixes the case where `cmake_source_dir` is set to a relative
directory outside of the `setup.py` directory (i.e `${cmake_source_dir}\some\dirs\setup.py`)

The fix is done by removing code originally introduced in 0d0ddbf
(setuptools_wrap: Add support for "cmake" and "hybrid" python package)
that was never covered by tests.

Fixes scikit-build#335
jcfr pushed a commit to massich/scikit-build that referenced this issue Jul 15, 2018
@massich @jcfr
Add a breaking test for issue scikit-build#335
d7e5ca6
jcfr pushed a commit to massich/scikit-build that referenced this issue Jul 15, 2018
@massich @jcfr
setuptools_wrap: Fix handling of relative parent cmake source dir
5e52d5c 
This commit fixes the case where `cmake_source_dir` is set to a relative
directory outside of the `setup.py` directory (i.e `${cmake_source_dir}\some\dirs\setup.py`)

The fix is done by removing code originally introduced in 0d0ddbf
(setuptools_wrap: Add support for "cmake" and "hybrid" python package)
that was never covered by tests.

Fixes scikit-build#335
jcfr added a commit to massich/scikit-build that referenced this issue Jul 15, 2018
@jcfr
CHANGES: Document fix and improvements related to scikit-build#335
1385689
@jcfr jcfr closed this as completed in #337 Jul 15, 2018
@jcfr jcfr mentioned this issue Jul 29, 2018
Closed
2 tasks
@jcfr jcfr added the Type: Feature Request Request for a new feature label May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Feature Request Request for a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for cmake_source_dir massich/scikit-build
1 participant
@jcfr