Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[OSX] skbuild.setup defaults cmake_args without checking kwargs for the arguments. #342
OS: OSX/Darwin (testing on travis).
Thanks for reporting the issue
Your proposed fix makes complete sense. Would be great if you could create a PR
To prevent future regression, I suggest you also add a test.
The test could be named
Since we only want to check if cmake is invoked with the expected parameter, you should mock both the upstream setup call and the call to CMaker.configure.
Here are some pointers:
I have found another bug, in
Thanks for following up with this
For this one, adding a new entry to the existing test is sensible.
It would be great to submit this change in a dedicated Pull Request referencing this issue.
Consider also updating CHANGES.rs