New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-tag is not recognized when specified in setup.cfg #353

Closed
bgermann opened this Issue Aug 1, 2018 · 8 comments

Comments

2 participants
@bgermann
Contributor

bgermann commented Aug 1, 2018

I try to build a wheel with setup.cfg containing

[bdist_wheel]
python-tag = py2.py3

This does not have any effect. E.g., the wheel still has the python tag cp36-cp36m. When I replace scikit-build with setuptools the tag py2.py3 is applied.

@jcfr

This comment has been minimized.

Contributor

jcfr commented Aug 1, 2018

Thanks for reporting the issue.

Seems settings set in setup.cfg are currently ignored. Could you reference here the documentation listing all tags expected to be supported ?

@jcfr jcfr changed the title from python-tag is not recognized to python-tag is not recognized when specified in setup.cfg Aug 1, 2018

@jcfr jcfr added the bug label Aug 1, 2018

@bgermann

This comment has been minimized.

Contributor

bgermann commented Aug 1, 2018

I do not think all settings in setup.cfg are ignored. I also set

[metadata]
license_file = LICENSE

and it is applied correctly. The possible python-tags are documented in PEP 425.

@jcfr

This comment has been minimized.

Contributor

jcfr commented Aug 1, 2018

Thanks for the follow up.

Would you also have a link to the corresponding documentation for setuptools (or distutils or wheels) ?

How do you currently specify the flag from the command line ?

@bgermann

This comment has been minimized.

Contributor

bgermann commented Aug 1, 2018

https://wheel.readthedocs.io/en/stable/ says "The –universal and –python-tag flags have no effect when used on a project that includes C extension code." -- so maybe that is why. Please close this issue if that is true for scikit-build.

@jcfr

This comment has been minimized.

Contributor

jcfr commented Aug 3, 2018

Thanks for looking up the details 👍 Since having binary wheels compatible with both python2 and python3 is not possible, this is most likely why this flag is not supported.

Before closing, few more questions ..

Would it be helpful if scikit-build report a clear message indicating that this option is not supported with a reference to the wheel documentation ?

I was wondering if would be able to share more details about your use case. Would you be able to share a link to your project ? Does it include compiled modules ?

@jcfr jcfr added question and removed bug labels Aug 3, 2018

@bgermann

This comment has been minimized.

Contributor

bgermann commented Aug 3, 2018

Documenting this would be helpful. The project includes a dynamic library that is called via ctypes.

@jcfr

This comment has been minimized.

Contributor

jcfr commented Aug 3, 2018

Would a note in here and here be appropriate ?

Or would it be more helpful for you to get a clear Runtime error with a descriptive message ?

@bgermann

This comment has been minimized.

Contributor

bgermann commented Aug 3, 2018

I think, these places are appropriate for the note.

I would prefer a note over an error because that is aligned with setuptools.

@jcfr jcfr closed this in b12febc Aug 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment