New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python-tag is not recognized when specified in setup.cfg #353
Comments
Thanks for reporting the issue. Seems settings set in |
I do not think all settings in setup.cfg are ignored. I also set
and it is applied correctly. The possible python-tags are documented in PEP 425. |
Thanks for the follow up. Would you also have a link to the corresponding documentation for setuptools (or distutils or wheels) ? How do you currently specify the flag from the command line ? |
https://wheel.readthedocs.io/en/stable/ says "The –universal and –python-tag flags have no effect when used on a project that includes C extension code." -- so maybe that is why. Please close this issue if that is true for scikit-build. |
Thanks for looking up the details 👍 Since having binary wheels compatible with both python2 and python3 is not possible, this is most likely why this flag is not supported. Before closing, few more questions .. Would it be helpful if scikit-build report a clear message indicating that this option is not supported with a reference to the wheel documentation ? I was wondering if would be able to share more details about your use case. Would you be able to share a link to your project ? Does it include compiled modules ? |
Documenting this would be helpful. The project includes a dynamic library that is called via ctypes. |
I think, these places are appropriate for the note. I would prefer a note over an error because that is aligned with setuptools. |
I try to build a wheel with setup.cfg containing
This does not have any effect. E.g., the wheel still has the python tag cp36-cp36m. When I replace scikit-build with setuptools the tag py2.py3 is applied.
The text was updated successfully, but these errors were encountered: