New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve argument parsing and --help output #118

Merged
merged 4 commits into from Aug 9, 2016

Conversation

5 participants
@msmolens
Member

msmolens commented Aug 8, 2016

Fixes #83

Note that the scikit-build options are still treated as global options as opposed to build subcommand options. #57 hints that perhaps we want to push some options down into the subcommand.

@codecov-io

This comment has been minimized.

codecov-io commented Aug 8, 2016

Current coverage is 67.98% (diff: 80.00%)

Merging #118 into master will increase coverage by 1.11%

@@             master       #118   diff @@
==========================================
  Files            17         18     +1   
  Lines           486        506    +20   
  Methods           0          0          
  Messages          0          0          
  Branches         93         96     +3   
==========================================
+ Hits            325        344    +19   
- Misses          124        125     +1   
  Partials         37         37          

Powered by Codecov. Last update dd98144...ff7489f

@AppVeyorBot

This comment has been minimized.

AppVeyorBot commented Aug 8, 2016

@AppVeyorBot

This comment has been minimized.

AppVeyorBot commented Aug 9, 2016

@msmolens msmolens force-pushed the arg-help branch from bb3d885 to 7674a83 Aug 9, 2016

@AppVeyorBot

This comment has been minimized.

AppVeyorBot commented Aug 9, 2016

msmolens added some commits Aug 4, 2016

Rework argument parsing and display scikit-build help
Help for scikit-build level options is displayed when --help is specified (build
type, generator, number of jobs). Help about passing arguments through to CMake
and the build tool is also displayed. CMake is not run when the user requests help.

Additionally, argument parsing is more robust:
- Fix specifying --build-type using an equals sign (e.g. --build-type=Debug)
- Abort with an error when too many "--" separators are provided.
Use specified build type in make step
This commit ensures that the build type specified on the command line is used in
the make step in addition to the configure step.

@msmolens msmolens force-pushed the arg-help branch from 7674a83 to ff7489f Aug 9, 2016

@AppVeyorBot

This comment has been minimized.

AppVeyorBot commented Aug 9, 2016

@jcfr jcfr merged commit 6eaf913 into master Aug 9, 2016

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 80.00% of diff hit (target 66.87%)
Details
codecov/project 67.98% (+1.11%) compared to dd98144
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jcfr jcfr deleted the arg-help branch Aug 9, 2016

@jcfr

This comment has been minimized.

Contributor

jcfr commented Aug 9, 2016

Nicee 👍

@opadron

This comment has been minimized.

Member

opadron commented Aug 31, 2016

This is great, @msmolens. On the subcommand matter, I don't think that work would be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment