New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmaker: Ensure CMAKE_* variables are passed to the test projects #256

Merged
merged 1 commit into from Jun 8, 2017

Conversation

2 participants
@jcfr
Contributor

jcfr commented Jun 8, 2017

No description provided.

@codecov-io

This comment has been minimized.

codecov-io commented Jun 8, 2017

Codecov Report

Merging #256 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
+ Coverage   91.01%   91.05%   +0.03%     
==========================================
  Files          26       26              
  Lines         935      939       +4     
  Branches      157      159       +2     
==========================================
+ Hits          851      855       +4     
  Misses         61       61              
  Partials       23       23
Impacted Files Coverage Δ
skbuild/cmaker.py 72.22% <100%> (ø) ⬆️
skbuild/platform_specifics/abstract.py 100% <100%> (ø) ⬆️
skbuild/__init__.py
.../cmakelists-not-in-top-level-dir/hello/__init__.py 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 216d064...9b0f65d. Read the comment docs.

cmaker: Ensure CMAKE_* variables are passed to generator check test p…
…rojects

Ensure CMake arguments passed to scikit-build and starting with ``-DCMAKE_*``
are passed to the test project allowing to determine which generator to use.
For example, this ensures that arguments like ``-DCMAKE_MAKE_PROGRAM:FILEPATH=/path/to/program``
are passed.

Co-authored-by: Matt McCormick <matt.mccormick@kitware.com>

@jcfr jcfr force-pushed the pass-cmake-args-to-test-project branch from 4ba7b55 to 9b0f65d Jun 8, 2017

@jcfr jcfr merged commit 9b0f65d into master Jun 8, 2017

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 91.01%)
Details
codecov/project 91.05% (+0.03%) compared to 8001f29
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@thewtex thewtex deleted the pass-cmake-args-to-test-project branch Jun 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment