New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for setting OSX plat_name from cmake args #377

Closed
wants to merge 3 commits into
base: master
from

Conversation

4 participants
@nonhermitian
Copy link
Contributor

nonhermitian commented Jan 4, 2019

It is possible to change the target OSX platform using --plat-name macosx-10.x-x86_64 or via the cmake args '-DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=10.x', '-DCMAKE_OSX_ARCHITECTURES:STRING=x86_64'. However, only the former sets the platform correctly for output wheels, e.g. via bdist_wheel. Therefore its is possible to build for macosx-10.9-x86_64, as required for the latest version of OSX, but have the output wheel still say macosx-10.6-x86_64.

This PR sets the plat_name for OSX from the cmake args if they are explicitly set by the user, and propagates this to the later build commands by appending to the sys.argv so that it behaves in the same manner as doing --plat-name macosx-10.x-x86_64

nonhermitian added some commits Jan 4, 2019

version = s.split('=')[1]
user_set = True
else:
version = '10.6'

This comment has been minimized.

@thewtex

thewtex Jan 7, 2019

Member

Now-a-days, I think 10.9 is more common, per

https://github.com/MacPython/wiki/wiki/Spinning-wheels

This comment has been minimized.

@nonhermitian

nonhermitian Jan 7, 2019

Author Contributor

Indeed. I think the primary build chain is still 10.7 on osx, but 10.9 is needed for the latest version. This is the motivation for this patch, but 10.6 was left as the default platform because modifying that is a separate issue.

@thewtex thewtex requested a review from jcfr Jan 7, 2019

@thewtex

This comment has been minimized.

Copy link
Member

thewtex commented Jan 7, 2019

@nonhermitian this is great!

@jcfr there seems to be some issue with the Python 3.5 / Windows build?

@atilag

This comment has been minimized.

Copy link

atilag commented Jan 7, 2019

Looking forward to seeing this PR merged!

@jcfr

This comment has been minimized.

Copy link
Contributor

jcfr commented Jan 7, 2019

there seems to be some issue with the Python 3.5 / Windows build?

The failure is due to appveyor timeout ... :(

@jcfr

This comment has been minimized.

Copy link
Contributor

jcfr commented Jan 7, 2019

@atilag Thanks for the contribution 👍
@thewtex Thanks for the review 👍

@atilag

This comment has been minimized.

Copy link

atilag commented Jan 8, 2019

Oh, the contribution is not mine! Credits go to @nonhermitian :)

@jcfr

This comment has been minimized.

Copy link
Contributor

jcfr commented Jan 9, 2019

Closing. This is superseded by #380

@jcfr jcfr closed this Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment