Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for nox, along with a bit of cleanup. @jcfr, I'd like to remove
Makefile
,tox.ini
, and maybescikit-ci.yml
in favor of nox as well.Nox is much simpler than tox, providing a clear, easy to read list of instructions rather than the somewhat magical incantations of tox that do not help a user to understand what is going on. Nox prints the exact commands in nice colors as it goes, in fact. Unlike make, it is integrated with virtual environments, so there's no setup required and no cleanup needed afterwards. The downside is it's a bit slower (a second or two is spent on preparing a virtual env), but repeatability is paramount for new users, not speed. Daily developers don't need to use nox on the tasks they are doing often (though I leave docs to nox pretty much always).
We don't have to use it in the CI, but we can.
I also want to move the linting driver to pre-commit in the near future, but we can allow that to be run from nox as a helper for new contributors, too.