Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build procedure building from setup.py. #129

Merged
merged 2 commits into from Mar 2, 2020

Conversation

jpivarski
Copy link
Member

@jpivarski jpivarski commented Feb 29, 2020

Still to do:

@jpivarski
Copy link
Member Author

Some baseline compilation times on a slow (Chromebook) computer:

  • full compilation time in release mode
real    3m20.192s
user    3m10.504s
sys     0m12.654s
  • linking-only in release mode
real    0m52.832s
user    0m50.578s
sys     0m3.352s
  • full compilation in debug mode
real    4m49.084s
user    4m45.499s
sys     0m14.281s
  • linking-only in debug mode
real    0m8.494s
user    0m6.615s
sys     0m1.735s

That's an interesting trade-off.

@jpivarski jpivarski force-pushed the feature/PR129-setuppy-no-cmake-dependence branch 2 times, most recently from 62755c1 to 5b4894b Compare February 29, 2020 16:20
jpivarski added a commit that referenced this pull request Feb 29, 2020
jpivarski added a commit that referenced this pull request Mar 1, 2020
…er'. (#130)

* [WIP] Rename 'FillableArray' to 'ArrayBuilder' and all 'fillable' to 'builder'.

* Successful name change.

* Move libawkward out of Numba again.

* Fix dependent project.

* [skip ci] Same VERSION_INFO as #129.
@jpivarski
Copy link
Member Author

@henryiii I've fully merged in #130 and tested it, including ArrayBuilder in Numba (which uses ctypes to access libawkward.so).

@henryiii henryiii force-pushed the feature/PR129-setuppy-no-cmake-dependence branch from 387217d to 190a065 Compare March 1, 2020 04:19
@henryiii henryiii changed the title [WIP] Remove the CMake dependence when building from setup.py. [WIP] Improve build procedure building from setup.py. Mar 1, 2020
@jpivarski jpivarski changed the title [WIP] Improve build procedure building from setup.py. Improve build procedure building from setup.py. Mar 2, 2020
@henryiii
Copy link
Member

henryiii commented Mar 2, 2020

Remember, we need to manually squash to 2-3 commits then rebase and merge, since we do a large renaming and several edits; if we just squash and merge git will loose the history tracking on the python files in src/awkward1. Let me know when you are ready and I can do it.

@jpivarski
Copy link
Member Author

@henryiii It's ready. Please do it.

@henryiii henryiii force-pushed the feature/PR129-setuppy-no-cmake-dependence branch from 6bd4297 to 0dadb72 Compare March 2, 2020 04:29
@jpivarski
Copy link
Member Author

I copied this branch as save/PR129-henryiii-build-procedure.

@jpivarski jpivarski merged commit 40be559 into master Mar 2, 2020
@jpivarski jpivarski deleted the feature/PR129-setuppy-no-cmake-dependence branch March 2, 2020 04:44
@ianna
Copy link
Collaborator

ianna commented Mar 4, 2020

@jpivarski and @henryiii - nice work, local builds are a lot faster! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants