Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace nplike with backend in to_buffers #1942

Merged
merged 4 commits into from Dec 2, 2022

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Dec 2, 2022

This follows up #1922 to remove any reference of nplike in the high level API, and renames nplikes to _nplikes

I also fixed the CUDA test generation, which I failed to fix in #1922

Note-to-self, write a git hook to run those.


📚 The documentation for this PR will be available at https://awkward-array.readthedocs.io/en/agoose77-feat-to-buffers-backend/ once Read the Docs has finished building 🔨

@agoose77 agoose77 added the pr-next-release Required for the next release label Dec 2, 2022
@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #1942 (916e295) into main (16d482a) will decrease coverage by 0.00%.
The diff coverage is 94.18%.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/_connect/rdataframe/from_rdataframe.py 0.00% <0.00%> (ø)
src/awkward/_nplikes.py 68.33% <0.00%> (ø)
src/awkward/operations/ak_from_parquet.py 88.72% <0.00%> (ø)
src/awkward/operations/ak_transform.py 83.05% <ø> (ø)
src/awkward/_connect/numpy.py 66.19% <75.00%> (ø)
src/awkward/contents/numpyarray.py 89.62% <77.77%> (ø)
src/awkward/operations/ak_to_buffers.py 90.00% <80.00%> (-10.00%) ⬇️
src/awkward/operations/ak_to_categorical.py 92.15% <83.33%> (ø)
src/awkward/contents/unionarray.py 85.71% <85.71%> (-0.15%) ⬇️
src/awkward/behaviors/string.py 76.02% <88.88%> (ø)
... and 112 more

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good: nplikes is now hidden and users deal with backends everywhere instead. I've scanned over the differences twice and they look like straightforward changes.

I'd like to merge this right away, since it will be easier to merge into my big PR now, rather than later.

@agoose77 agoose77 merged commit 9e2b535 into main Dec 2, 2022
@agoose77 agoose77 deleted the agoose77/feat-to-buffers-backend branch December 2, 2022 23:48
@jpivarski jpivarski removed the pr-next-release Required for the next release label Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants