From 95745d2d639a878565ada46c7ef9d31ee5bffe46 Mon Sep 17 00:00:00 2001 From: Henry Schreiner Date: Thu, 13 Jul 2023 15:17:13 -0500 Subject: [PATCH 1/3] ci: try action-lint-annotations Signed-off-by: Henry Schreiner --- .github/matchers/pylint.json | 32 -------------------------------- .github/workflows/ci.yml | 5 ++--- 2 files changed, 2 insertions(+), 35 deletions(-) delete mode 100644 .github/matchers/pylint.json diff --git a/.github/matchers/pylint.json b/.github/matchers/pylint.json deleted file mode 100644 index e3a6bd16..00000000 --- a/.github/matchers/pylint.json +++ /dev/null @@ -1,32 +0,0 @@ -{ - "problemMatcher": [ - { - "severity": "warning", - "pattern": [ - { - "regexp": "^([^:]+):(\\d+):(\\d+): ([A-DF-Z]\\d+): \\033\\[[\\d;]+m([^\\033]+).*$", - "file": 1, - "line": 2, - "column": 3, - "code": 4, - "message": 5 - } - ], - "owner": "pylint-warning" - }, - { - "severity": "error", - "pattern": [ - { - "regexp": "^([^:]+):(\\d+):(\\d+): (E\\d+): \\033\\[[\\d;]+m([^\\033]+).*$", - "file": 1, - "line": 2, - "column": 3, - "code": 4, - "message": 5 - } - ], - "owner": "pylint-error" - } - ] -} diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 69280a80..d8e53a9d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -21,11 +21,10 @@ jobs: - uses: actions/setup-python@v4 with: python-version: "3.x" + - uses: wandnz/action-lint-annotations@v1 - uses: pre-commit/action@v3.0.0 - name: PyLint - run: | - echo "::add-matcher::$GITHUB_WORKSPACE/.github/matchers/pylint.json" - pipx run nox -s pylint + run: pipx run nox -s pylint checks: runs-on: ubuntu-latest From 2a84b05128d9fc17d25c57e6505926ecd83e2489 Mon Sep 17 00:00:00 2001 From: Henry Schreiner Date: Thu, 13 Jul 2023 15:21:01 -0500 Subject: [PATCH 2/3] WIP: try creating lint failure Signed-off-by: Henry Schreiner --- src/hist/basehist.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/hist/basehist.py b/src/hist/basehist.py index cc008b7a..c7a9b6f0 100644 --- a/src/hist/basehist.py +++ b/src/hist/basehist.py @@ -72,6 +72,7 @@ def __init__( self.axes: NamedAxesTuple self.name = name self.label = label + useless = None if args and storage is None and isinstance(args[-1], (Storage, str)): storage = args[-1] From 0594d2d0140ebdc4b044d7ada9a4c78d865bdaa1 Mon Sep 17 00:00:00 2001 From: Henry Schreiner Date: Thu, 20 Jul 2023 16:47:11 -0400 Subject: [PATCH 3/3] Update ci.yml --- .github/workflows/ci.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d8e53a9d..5d05fd21 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -6,9 +6,6 @@ on: branches: - main -env: - FORCE_COLOR: 3 - concurrency: group: ${ github.workflow }-${ github.head_ref } cancel-in-progress: true