Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort input file list #355

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@bmwiedemann
Copy link
Contributor

commented Sep 10, 2019

Sort input file list
so that _libiminuit.so builds in a reproducible way
in spite of indeterministic filesystem readdir order
and http://bugs.python.org/issue30461

See https://reproducible-builds.org/ for why this is good.

This PR was done while working on reproducible builds for openSUSE.

so that _libiminuit.so builds in a reproducible way
in spite of indeterministic filesystem readdir order
and http://bugs.python.org/issue30461

See https://reproducible-builds.org/ for why this is good.
@codecov

This comment has been minimized.

Copy link

commented Sep 10, 2019

Codecov Report

Merging #355 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #355   +/-   ##
========================================
  Coverage    65.71%   65.71%           
========================================
  Files          137      137           
  Lines         4431     4431           
  Branches       651      651           
========================================
  Hits          2912     2912           
  Misses        1281     1281           
  Partials       238      238

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18ea7b2...f6f8785. Read the comment docs.

@HDembinski HDembinski merged commit d0ed6a3 into scikit-hep:develop Sep 11, 2019
5 checks passed
5 checks passed
WIP Ready for review
Details
codecov/patch Coverage not affected when comparing 18ea7b2...f6f8785
Details
codecov/project 65.71% remains the same compared to 18ea7b2
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@HDembinski

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

If I understand correctly, this change may help to make all binaries from the same build environment identical, which is certainly a good thing. Thank you for the PR!

@bmwiedemann

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

Yes, that is the goal.
Thanks for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.