Skip to content

Test all the Jupyter notebooks in the CI #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthewfeickert opened this issue May 13, 2018 · 0 comments
Open

Test all the Jupyter notebooks in the CI #168

matthewfeickert opened this issue May 13, 2018 · 0 comments
Assignees
Labels
docs Documentation related feat/enhancement New feature or request good first issue Good for newcomers

Comments

@matthewfeickert
Copy link
Member

As pointed out in PR #167 we currently don't test all the Jupyter notebooks even though they all end up in the docs (well, with the exception of the Binder test notebook which the docs don't pick up (do we want them to?)). Instead we only test a few core notebooks:

  • ShapeFactor.ipynb
  • multichannel-coupled-histo.ipynb
  • multiBinPois.ipynb

Ideally if something ends up in the docs it should really be tested first, so we should add testing of all the notebooks to test_notebooks.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related feat/enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant