Test all public methods of classes (mainly pdf.Model)

[lukasheinrich]

Description

In https://github.com/diana-hep/pyhf/pull/269 we have seen a decrease in coverage because we relied on nested calls to methods to traverse the calls. A refactoring of the internal code then left some methods uncovered.

We should make sure that all public methods of classes (mainly pyhf.pdf.Model) are tested explicitly or remote them to internal methods by prepending a underscore. Otherwise refactorings might break users relying on these methods

(somewhat related to semantic versioning )

Classes

• pyhf.pdf.Model
  • expected_auxdata
  • expected_actualdata
  • expected_sample
  • expected_data
  • constraint_logpdf
  • logpdf
  • pdf

Relevant Issues and Pull Requests

If there are relevant issues and pull requests for this feature please list and link them here

• precomputes all modifications at once #269

[kratsg]

#611 will address this somewhat.