pathlib.Path drops '//' (naturally), but it's sometimes used for URLs #670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So if a path from
pathlib.Path
starts with "http:/" and no second slash (also for "file", "https", "root" URL schemes, case insensitive), then a second slash will be added.pathlib.Path
is our recommended way of saying, "This really is a path, even though it has a colon in it," but we didn't foresee this issue with URLs with colons in them.There's another way of doing it with
{filename: None}
instead ofpathlib.Path(filename)
, which doesn't suffer from this, but enough people are probably doing thepathlib.Path
thing that we need this small correction.