Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for TLeafG #840

Merged
merged 21 commits into from Feb 23, 2023
Merged

feat: add support for TLeafG #840

merged 21 commits into from Feb 23, 2023

Conversation

ioanaif
Copy link
Collaborator

@ioanaif ioanaif commented Feb 22, 2023

This PR address issue #761 and adds support for TLeafG

@ioanaif ioanaif changed the title fix: add support for TLeafG feat: add support for TLeafG Feb 23, 2023
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just detangling the which-format-attribute-goes-with-which-class.

(We're doing the reviews live in a Zoom call.)

src/uproot/models/TLeaf.py Outdated Show resolved Hide resolved
src/uproot/models/TLeaf.py Outdated Show resolved Hide resolved
src/uproot/models/TLeaf.py Outdated Show resolved Hide resolved
@ioanaif ioanaif linked an issue Feb 23, 2023 that may be closed by this pull request
ioanaif and others added 8 commits February 23, 2023 16:16
@jpivarski
Copy link
Member

Looks great! Feel free to merge when you're ready.

@ioanaif ioanaif merged commit 0b0fa0b into main Feb 23, 2023
16 checks passed
@ioanaif ioanaif deleted the ioanaif/support-tleafg branch February 23, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for TLeafG
2 participants