Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix active contour gallery example after change to rc coordinates #4257

Merged
merged 1 commit into from Oct 21, 2019

Conversation

sciunto
Copy link
Member

@sciunto sciunto commented Oct 18, 2019

Description

PR #4035 changed the active contour example to use rc coordinates rather than xy, but it did not update the matplotlib code, resulting in transposed contours. This change fixes that oversight.

Fixes #4253

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • Consider backporting the PR with @meeseeksdev backport to v0.14.x

@sciunto sciunto added the ⚠️ Critical Reserved for newly introduced bugs in a final release label Oct 18, 2019
@sciunto sciunto requested review from soupault and jni October 18, 2019 19:46
@sciunto sciunto changed the title Fix after #4035 Active contour Fix gallery after #4035 Oct 18, 2019
@hmaarrfk
Copy link
Member

These really need a before and after.

@jni jni changed the title Active contour Fix gallery after #4035 Fix active contour gallery example after change to rc coordinates Oct 21, 2019
@jni jni merged commit 5cb1b34 into scikit-image:master Oct 21, 2019
@jni
Copy link
Member

jni commented Oct 21, 2019

@sciunto (and everyone) we haven't yet made a comment about it, but one of the issues @NelleV encountered while compiling the release notes is that many PRs don't provide sufficient information in the title and comments to make an informed decision about how to highlight that PR. This required excessive clicking through to fully understand a PR. Therefore, let's make an effort to write coherent summaries in the PR title and description.

btw, not to single you out at all, Nelle pointed out one of my PRs as a salient example. 😂 🤦‍♂

@sciunto sciunto deleted the fixActiveContour branch October 21, 2019 06:48
@sciunto
Copy link
Member Author

sciunto commented Oct 21, 2019

Thanks for the comment, i'll try to improve that as well.

@jni
Copy link
Member

jni commented Oct 21, 2019

Oh! And:

@jni
Copy link
Member

jni commented Oct 21, 2019

@meeseeksdev backport to v0.16.x

@jni
Copy link
Member

jni commented Oct 21, 2019

=P

meeseeksmachine pushed a commit to meeseeksmachine/scikit-image that referenced this pull request Oct 21, 2019
soupault added a commit that referenced this pull request Oct 21, 2019
…7-on-v0.16.x

Backport PR #4257 on branch v0.16.x (Fix active contour gallery example after change to rc coordinates)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ Critical Reserved for newly introduced bugs in a final release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orientation in plot_active_contours example is broken
3 participants