New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyramid_gaussian support for float32 #4696
Add pyramid_gaussian support for float32 #4696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rfezzani !
|
||
@pytest.mark.parametrize('dtype, expected', | ||
zip(['float32', 'float64', 'uint8', 'int64'], | ||
['float32', 'float64', 'float64', 'float64'])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A list of tuples would have been clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hesitated =)
@meeseeksdev backport to v0.17.x |
Thank you 🎉 |
Description
Fixes #4695. This PR is prerequisite to add full
float32
support toORB
in #4697.Checklist
./doc/examples
(new features only)./benchmarks
, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py
.doc/release/release_dev.rst
.