Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pyramid_gaussian support for float32 #4696

Merged
merged 1 commit into from May 12, 2020
Merged

Add pyramid_gaussian support for float32 #4696

merged 1 commit into from May 12, 2020

Conversation

rfezzani
Copy link
Member

@rfezzani rfezzani commented May 12, 2020 •
edited

Description

Fixes #4695. This PR is prerequisite to add full float32 support to ORB in #4697.

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@rfezzani rfezzani added type: bug ⚠️ Critical Reserved for newly introduced bugs in a final release 🩹 type: Bug fix Fixes unexpected or incorrect behavior and removed type: bug labels May 12, 2020
@rfezzani rfezzani mentioned this pull request May 12, 2020
Merged
8 tasks
emmanuelle
emmanuelle approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@emmanuelle emmanuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rfezzani !

hmaarrfk
hmaarrfk reviewed May 12, 2020
View reviewed changes
skimage/transform/tests/test_pyramids.py

@pytest.mark.parametrize('dtype, expected',
zip(['float32', 'float64', 'uint8', 'int64'],
['float32', 'float64', 'float64', 'float64']))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A list of tuples would have been clearer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hesitated =)

@hmaarrfk hmaarrfk merged commit 48945db into scikit-image:master May 12, 2020
@emmanuelle
Copy link
Member

@meeseeksdev backport to v0.17.x

meeseeksmachine pushed a commit to meeseeksmachine/scikit-image that referenced this pull request May 12, 2020
@hmaarrfk @meeseeksmachine
Backport PR scikit-image#4696: Add pyramid_gaussian support for float32
fc7c542
@meeseeksmachine meeseeksmachine mentioned this pull request May 12, 2020
Closed
@rfezzani
Copy link
Member Author

Thank you 🎉

@alexdesiqueira alexdesiqueira mentioned this pull request May 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmaarrfk hmaarrfk hmaarrfk approved these changes

@emmanuelle emmanuelle emmanuelle approved these changes

Assignees
No one assigned
Labels
🩹 type: Bug fix Fixes unexpected or incorrect behavior ⚠️ Critical Reserved for newly introduced bugs in a final release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pyramid_gaussian doesn't support float32
3 participants
@rfezzani @emmanuelle @hmaarrfk