Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let tifffile.imread handle additional keyword arguments #4997

Merged
merged 1 commit into from Oct 2, 2020
Merged

Let tifffile.imread handle additional keyword arguments #4997

merged 1 commit into from Oct 2, 2020

Conversation

cgohlke
Copy link
Contributor

@cgohlke cgohlke commented Oct 1, 2020

Description

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

@rfezzani rfezzani added 🔧 type: Maintenance Refactoring and maintenance of internals ⏩ type: Enhancement Improve existing features and removed 🔧 type: Maintenance Refactoring and maintenance of internals labels Oct 2, 2020
Copy link
Member

@rfezzani rfezzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cgohlke, thank you! Just adding a test would be perfect 😉

@cgohlke
Copy link
Contributor Author

cgohlke commented Oct 2, 2020

I think this is already tested:

def test_tifffile_kwarg_passthrough ():
img = imread(fetch('data/multipage.tif'), key=[1],
multifile=False, multifile_close=True, fastij=True,
is_ome=True)
assert img.shape == (15, 10), img.shape

@emmanuelle
Copy link
Member

Thank you so much @cgohlke. We really appreciate your help.

@emmanuelle emmanuelle merged commit 94ccb86 into scikit-image:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏩ type: Enhancement Improve existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants