Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible bug in adasyn.py #354

Closed
adihajjahmad1 opened this issue Oct 10, 2017 · 2 comments
Closed

possible bug in adasyn.py #354

adihajjahmad1 opened this issue Oct 10, 2017 · 2 comments

Comments

@adihajjahmad1
Copy link

@adihajjahmad1 adihajjahmad1 commented Oct 10, 2017

In Line 207 << x_class_gen.append([x_i + step * (X[x_i_nn[nn_z], :] - x_i) >>, seems to me X should be replaced with X_class as the Nearest Neighbor was re-computed based on X_class prior to entering the for loop.

@glemaitre
Copy link
Member

@glemaitre glemaitre commented Oct 11, 2017

I think that you are right. I will check on my own but you can submit a PR if you wish.

@glemaitre
Copy link
Member

@glemaitre glemaitre commented Oct 11, 2017

The bug was introduced when refactor SMOTE and ADASYN. Good catch.The visual plot make much more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants