Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

possible bug in adasyn.py #354

Closed
adihajjahmad1 opened this issue Oct 10, 2017 · 2 comments · Fixed by #355
Closed

possible bug in adasyn.py #354

adihajjahmad1 opened this issue Oct 10, 2017 · 2 comments · Fixed by #355
Labels
Type: Bug Indicates an unexpected problem or unintended behavior

Comments

@adihajjahmad1
Copy link

In Line 207 << x_class_gen.append([x_i + step * (X[x_i_nn[nn_z], :] - x_i) >>, seems to me X should be replaced with X_class as the Nearest Neighbor was re-computed based on X_class prior to entering the for loop.
@glemaitre
Copy link
Member

I think that you are right. I will check on my own but you can submit a PR if you wish.

@glemaitre glemaitre added the Type: Bug Indicates an unexpected problem or unintended behavior label Oct 11, 2017
@glemaitre
Copy link
Member

The bug was introduced when refactor SMOTE and ADASYN. Good catch.The visual plot make much more sense.

@glemaitre glemaitre mentioned this issue Oct 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG] FIX consider only current class when generating sample in ADASYN glemaitre/imbalanced-learn
2 participants
@glemaitre @adihajjahmad1