Skip to content

possible bug in adasyn.py #354

Description

@adihajjahmad1

In Line 207 << x_class_gen.append([x_i + step * (X[x_i_nn[nn_z], :] - x_i) >>, seems to me X should be replaced with X_class as the Nearest Neighbor was re-computed based on X_class prior to entering the for loop.

Activity

  1. glemaitre commented on Oct 11, 2017

    @glemaitre
    Member

    I think that you are right. I will check on my own but you can submit a PR if you wish.

  2. added
    Type: BugIndicates an unexpected problem or unintended behavior
    on Oct 11, 2017
  3. glemaitre commented on Oct 11, 2017

    @glemaitre
    Member

    The bug was introduced when refactor SMOTE and ADASYN. Good catch.The visual plot make much more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type: BugIndicates an unexpected problem or unintended behavior

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions