Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Refactor `ratio` #411

Closed
glemaitre opened this issue Mar 1, 2018 · 4 comments
Closed

[RFC] Refactor `ratio` #411

glemaitre opened this issue Mar 1, 2018 · 4 comments
Labels

Comments

@glemaitre
Copy link
Member

@glemaitre glemaitre commented Mar 1, 2018

ratio is still a bit of a weird parameters. Here is a proposal for further development:

  • remove the deprecation regarding float as ratio which is a valid parameter with binary target.
  • 'all' in over-sampling should be changed to 'not majority'. This is currently doing the same process but this is weird for the user.
  • cleaning methods should have their own ratio type. str should be accepted but dict should be replaced by a list since we cannot select how many sample to select. Also float would not be accepted for the exact same reason.

ratio should also be renamed. My proposal sampling_target?

@glemaitre glemaitre changed the title Refactor `ratio` [RFC] Refactor `ratio` Mar 1, 2018
@glemaitre glemaitre added the For: API label Mar 1, 2018
@glemaitre
Copy link
Member Author

@glemaitre glemaitre commented Mar 1, 2018

@amueller @chkoar @jorisvandenbossche
Any remarks is welcomed.

@amueller
Copy link
Member

@amueller amueller commented Mar 1, 2018

I don't really know where and how this is used to give feedback, I think.

@massich
Copy link
Contributor

@massich massich commented Mar 19, 2018

are we talking about this ratio?

@glemaitre
Copy link
Member Author

@glemaitre glemaitre commented Mar 19, 2018

yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants