Skip to content

MAINT drop disutils and use scikit-learn fixes instead - #1065

Merged
glemaitre merged 6 commits into
scikit-learn-contrib:masterfrom
mr-c:distutils_deprecated
Mar 31, 2024
Merged

MAINT drop disutils and use scikit-learn fixes instead#1065
glemaitre merged 6 commits into
scikit-learn-contrib:masterfrom
mr-c:distutils_deprecated

Conversation

@mr-c

@mr-c mr-c commented Feb 27, 2024

Copy link
Copy Markdown
Contributor

What does this implement/fix? Explain your changes.

Distutils is deprecated. Use the equivalent function from the packaging package instead. Pytest and others already depend on that, but I added it to the test dependencies to be sure.

Any other comments?

This patch was needed in the Debian package of imbalanced-learn.

This patch was needed in Debian

Co-authored-by: Michael R. Crusoe <crusoe@debian.org>

@glemaitre glemaitre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll need to make a release for that one.

Comment thread imblearn/tensorflow/tests/test_generator.py Outdated
@glemaitre
glemaitre self-requested a review March 30, 2024 17:54
@glemaitre glemaitre changed the title Distutils is deprecated, drop it MAINT drop disutils and use scikit-learn fixes instead Mar 31, 2024
@glemaitre
glemaitre merged commit a0e8e0f into scikit-learn-contrib:master Mar 31, 2024
glemaitre added a commit that referenced this pull request Mar 31, 2024
Co-authored-by: Nilesh Patra <nilesh@debian.org>
Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants