New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow None objects in Pipeline chain #231

Merged
merged 1 commit into from Mar 11, 2017

Conversation

Projects
None yet
3 participants
@chkoar
Member

chkoar commented Feb 9, 2017

Reference Issue

Fixes #226

What does this implement/fix? Explain your changes.

Pipeline should allow None objects in prepossessing steps. With this modification
one could use *SearchCV estimators and examine if the performance of the final
classifier is improved by using a sampler or not.

@coveralls

This comment has been minimized.

coveralls commented Feb 9, 2017

Coverage Status

Coverage decreased (-0.2%) to 98.687% when pulling 257d386 on chkoar:pipeline_patch1 into 4e885ae on scikit-learn-contrib:master.

1 similar comment
@coveralls

This comment has been minimized.

coveralls commented Feb 9, 2017

Coverage Status

Coverage decreased (-0.2%) to 98.687% when pulling 257d386 on chkoar:pipeline_patch1 into 4e885ae on scikit-learn-contrib:master.

@chkoar

This comment has been minimized.

Member

chkoar commented Feb 21, 2017

@glemaitre do we need a test case for this?

@glemaitre

This comment has been minimized.

Member

glemaitre commented Feb 21, 2017

Yep.

@chkoar chkoar force-pushed the chkoar:pipeline_patch1 branch from 257d386 to b3e15b1 Feb 22, 2017

@chkoar chkoar requested a review from glemaitre Feb 22, 2017

@chkoar chkoar changed the title from [WIP] Allow None objects in Pipeline chain to Allow None objects in Pipeline chain Feb 22, 2017

@coveralls

This comment has been minimized.

coveralls commented Feb 22, 2017

Coverage Status

Coverage decreased (-0.2%) to 98.764% when pulling b3e15b1 on chkoar:pipeline_patch1 into 537bf78 on scikit-learn-contrib:master.

pipe = make_pipeline(None, clf)
pipe.fit(X, y)
pipe.score(X, y)

This comment has been minimized.

@glemaitre

glemaitre Feb 23, 2017

Member

You need 2 blanks line

@glemaitre

This comment has been minimized.

Member

glemaitre commented Feb 23, 2017

Check the PEP8. Otherwise LGTM

@chkoar chkoar force-pushed the chkoar:pipeline_patch1 branch from b3e15b1 to 4be0556 Feb 23, 2017

@coveralls

This comment has been minimized.

coveralls commented Feb 23, 2017

Coverage Status

Coverage decreased (-0.2%) to 98.764% when pulling 4be0556 on chkoar:pipeline_patch1 into 537bf78 on scikit-learn-contrib:master.

@glemaitre

This comment has been minimized.

Member

glemaitre commented Feb 23, 2017

@chkoar could you make such that we have full coverage on the new line https://coveralls.io/builds/10292465/source?filename=imblearn%2Fpipeline.py

@chkoar

This comment has been minimized.

Member

chkoar commented Feb 23, 2017

Of course. I think that we need test cases to cover those lines, no?

@glemaitre

This comment has been minimized.

Member

glemaitre commented Feb 23, 2017

yep

@chkoar chkoar force-pushed the chkoar:pipeline_patch1 branch from 4be0556 to 2e10c36 Mar 8, 2017

@coveralls

This comment has been minimized.

coveralls commented Mar 8, 2017

Coverage Status

Coverage decreased (-0.2%) to 98.769% when pulling 2e10c36 on chkoar:pipeline_patch1 into 281d005 on scikit-learn-contrib:master.

1 similar comment
@coveralls

This comment has been minimized.

coveralls commented Mar 8, 2017

Coverage Status

Coverage decreased (-0.2%) to 98.769% when pulling 2e10c36 on chkoar:pipeline_patch1 into 281d005 on scikit-learn-contrib:master.

@chkoar chkoar force-pushed the chkoar:pipeline_patch1 branch 2 times, most recently from 8581257 to 2d4a6e2 Mar 8, 2017

@coveralls

This comment has been minimized.

coveralls commented Mar 8, 2017

Coverage Status

Coverage decreased (-0.03%) to 98.9% when pulling 2d4a6e2 on chkoar:pipeline_patch1 into 281d005 on scikit-learn-contrib:master.

@coveralls

This comment has been minimized.

coveralls commented Mar 8, 2017

Coverage Status

Coverage decreased (-0.03%) to 98.9% when pulling 2d4a6e2 on chkoar:pipeline_patch1 into 281d005 on scikit-learn-contrib:master.

@chkoar chkoar force-pushed the chkoar:pipeline_patch1 branch from 2d4a6e2 to 24c97b8 Mar 8, 2017

@coveralls

This comment has been minimized.

coveralls commented Mar 8, 2017

Coverage Status

Coverage increased (+0.02%) to 98.951% when pulling 24c97b8 on chkoar:pipeline_patch1 into 281d005 on scikit-learn-contrib:master.

@chkoar chkoar force-pushed the chkoar:pipeline_patch1 branch from 24c97b8 to 36ab484 Mar 8, 2017

@coveralls

This comment has been minimized.

coveralls commented Mar 8, 2017

Coverage Status

Coverage increased (+0.02%) to 98.951% when pulling 36ab484 on chkoar:pipeline_patch1 into 281d005 on scikit-learn-contrib:master.

@chkoar

This comment has been minimized.

Member

chkoar commented Mar 8, 2017

@glemaitre +0.02%

@glemaitre

This comment has been minimized.

Member

glemaitre commented Mar 10, 2017

@chkoar Add info in the whats new and I will merge it

@chkoar chkoar force-pushed the chkoar:pipeline_patch1 branch from 36ab484 to c5338b0 Mar 11, 2017

@chkoar

This comment has been minimized.

Member

chkoar commented Mar 11, 2017

@glemaitre done.

@coveralls

This comment has been minimized.

coveralls commented Mar 11, 2017

Coverage Status

Coverage decreased (-0.03%) to 98.901% when pulling c5338b0 on chkoar:pipeline_patch1 into 281d005 on scikit-learn-contrib:master.

@coveralls

This comment has been minimized.

coveralls commented Mar 11, 2017

Coverage Status

Coverage increased (+0.02%) to 98.951% when pulling c5338b0 on chkoar:pipeline_patch1 into 281d005 on scikit-learn-contrib:master.

@glemaitre glemaitre merged commit aed7a97 into scikit-learn-contrib:master Mar 11, 2017

4 checks passed

code-quality/landscape Code quality increased by 0.01%
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 98.951%
Details

christophe-rannou pushed a commit to christophe-rannou/imbalanced-learn that referenced this pull request Apr 3, 2017

glemaitre added a commit to glemaitre/imbalanced-learn that referenced this pull request Jun 15, 2017

glemaitre added a commit to glemaitre/imbalanced-learn that referenced this pull request Jun 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment