Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Remove seaborn dependencies #264

Merged
merged 18 commits into from
Mar 30, 2017
Merged

Conversation

glemaitre
Copy link
Member

@glemaitre glemaitre commented Mar 22, 2017

Reference Issue

Fixes #257
Fixes #265

What does this implement/fix? Explain your changes.

The examples are currently relying on searborn. We should modify them to purely rely on matplotlib.
Additionally, the following examples are improved:

  • ensemble methods -> better illustration of the methods
  • instance threshold hardness -> better illustration of the ratio
  • allknn/RENN/ENN -> the examples has been merged
  • SMOTE -> merge all SMOTE together
  • Nearmiss -> Merge all nearmiss together

Any other comments?

@pep8speaks
Copy link

pep8speaks commented Mar 22, 2017

Hello @glemaitre! Thanks for updating the PR.

Line 62:1: E128 continuation line under-indented for visual indent
Line 63:1: E128 continuation line under-indented for visual indent
Line 64:1: E901 TokenError: EOF in multi-line statement

Comment last updated on March 23, 2017 at 12:15 Hours UTC

@codecov
Copy link

codecov bot commented Mar 22, 2017

Codecov Report

Merging #264 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #264   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files          58       58           
  Lines        3427     3427           
=======================================
  Hits         3368     3368           
  Misses         59       59

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a55e37d...c20f09a. Read the comment docs.

@glemaitre glemaitre changed the title [WIP] Remove seaborn dependencies [MRG] Remove seaborn dependencies Mar 23, 2017
@glemaitre glemaitre changed the title [MRG] Remove seaborn dependencies [WIP] Remove seaborn dependencies Mar 23, 2017
@glemaitre glemaitre changed the title [WIP] Remove seaborn dependencies [MRG] Remove seaborn dependencies Mar 23, 2017
@glemaitre
Copy link
Member Author

@chkoar I think that they are nicer now:

https://548-36019880-gh.circle-artifacts.com/0/home/ubuntu/imbalanced-learn/doc/_build/html/auto_examples/index.html

You can check the results with the artifacts.

@chkoar
Copy link
Member

chkoar commented Mar 23, 2017

@glemaitre yeap indeed they are!

I think that the legend for the next examples has to be fixed because overlaps wight X dimension

under-sampling-plot-enn-renn-allknn
under-sampling-plot-nearmiss
plot-instance-hardness-threshold
ver-sampling-plot-smote

@glemaitre
Copy link
Member Author

Thanks, locally I didn't have this issue. I will check those.

@glemaitre glemaitre force-pushed the is/257 branch 2 times, most recently from d6aa52d to 3d61933 Compare March 23, 2017 12:14
@glemaitre glemaitre changed the title [MRG] Remove seaborn dependencies [WIP] Remove seaborn dependencies Mar 23, 2017
@glemaitre glemaitre force-pushed the is/257 branch 3 times, most recently from ca1f9b7 to d90f5b5 Compare March 25, 2017 15:17
@glemaitre glemaitre force-pushed the is/257 branch 2 times, most recently from 08d1da8 to a2c0032 Compare March 25, 2017 16:41
@glemaitre glemaitre changed the title [WIP] Remove seaborn dependencies [MRG] Remove seaborn dependencies Mar 25, 2017
@glemaitre
Copy link
Member Author

@chkoar Check the artifacts but I think that this is fine this time.

@glemaitre glemaitre changed the title [MRG] Remove seaborn dependencies [WIP] Remove seaborn dependencies Mar 26, 2017
@glemaitre glemaitre changed the title [WIP] Remove seaborn dependencies [MRG] Remove seaborn dependencies Mar 26, 2017
@chkoar chkoar merged commit 5ca3037 into scikit-learn-contrib:master Mar 30, 2017
glemaitre added a commit to glemaitre/imbalanced-learn that referenced this pull request Jun 15, 2017
glemaitre added a commit to glemaitre/imbalanced-learn that referenced this pull request Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create better examples MAINT Remove seaborn depedencies in plots
3 participants