-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Remove seaborn dependencies #264
Conversation
Hello @glemaitre! Thanks for updating the PR.
Comment last updated on March 23, 2017 at 12:15 Hours UTC |
Codecov Report
@@ Coverage Diff @@
## master #264 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 58 58
Lines 3427 3427
=======================================
Hits 3368 3368
Misses 59 59 Continue to review full report at Codecov.
|
@chkoar I think that they are nicer now: You can check the results with the artifacts. |
@glemaitre yeap indeed they are! I think that the legend for the next examples has to be fixed because overlaps wight X dimension
|
Thanks, locally I didn't have this issue. I will check those. |
d6aa52d
to
3d61933
Compare
ca1f9b7
to
d90f5b5
Compare
08d1da8
to
a2c0032
Compare
@chkoar Check the artifacts but I think that this is fine this time. |
Reference Issue
Fixes #257
Fixes #265
What does this implement/fix? Explain your changes.
The examples are currently relying on searborn. We should modify them to purely rely on matplotlib.
Additionally, the following examples are improved:
Any other comments?